power limiting initial run #1734
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucien950
requested changes
Oct 2, 2025
| @@ -1,5 +1,6 @@ | |||
| #pragma once | |||
| #include <stdint.h> | |||
| #include <stdnoreturn.h> | |||
Contributor
There was a problem hiding this comment.
damn I didn't even know about that
| void app_powerLimiting_torqueReduction(PowerLimitingInputs *inputs); | ||
|
|
||
| void app_power_limiting_TestRun_Torque_Reduction(PowerLimitingInputs *inputs); | ||
| app_pwer_limiting_TestRun_OverCurrent_Timer_Init(void); |
Contributor
There was a problem hiding this comment.
wait why is BSPD not a warning warning and it's this seperate thing?
Contributor
There was a problem hiding this comment.
also surely warnings should also papps to 0?
Comment on lines
181
to
189
Contributor
There was a problem hiding this comment.
can you disable everything else?
Comment on lines
92
to
119
Contributor
There was a problem hiding this comment.
disable everything else please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cook my shit. Happy to add unit tests btw
FIRM-476