randoms from singles fixes#1331
Merged
KrisThielemans merged 6 commits intoUCL:masterfrom Jan 14, 2024
Merged
Conversation
KrisThielemans
force-pushed
the
RFSfixes
branch
from
283a2aa to
d17bf84
Compare
The name and location is hopefully more logical. Throw error if it is unknown. To enable this, set max_num_timing_poss=1 for non-TOF scanners (it was 0 for most). Add coincidence-window tests to Scanner:check_consistency Moved the "TOF_time <-> mm" functions to TOF_conversions.h Fixes UCL#1330
we now have it in Scanner
- get_all_det_pos_pairs_for_bin now defaults to ignore TOF. This is probably what is expected by most people. - fix multiply_crystal_factors for TOF (in the previous version, it was unexpectedly running over all unmashed TOF bins, giving the wrong scale factor, and taking a long time
KrisThielemans
force-pushed
the
RFSfixes
branch
from
d17bf84 to
9b40626
Compare
Collaborator
Author
|
@NicoleJurjew @danieldeidda @NikEfth this contains some changes that are not backwards compatible with previous TOF stuff. You might get compilation errors, but I hope the change is obvious enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RFS for TOF. Scale is currently wrong.
But first fixes #1330