Conversation
Issue: Ruler icon was turning white and blending with button background when selected. Changes: Replaced undefined CSS variable 'var(--heading-gray)' with 'var(--light-grey)' to ensure proper contrast between icon and button background.
Issue: When dragging the animation slider back to the very beginning, the first plume would disappear from the map. Changes: Moved initial plume display call outside of timeline onStart handler to ensure the first plume is properly rendered before timeline initialization.
- Calculate min/max dates from regions data dynamically - Add minDate and maxDate constraints to DatePicker components - Grey out dates outside available data range - Update filter dates when temporal extent changes - Add reset functionality to restore date range on home button click Addresses recommendation to limit date selection to available data range
- Fix replay button starting animation in the middle by correcting timestamp parsing.
slesaad
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses several UI/UX improvements and bug fixes for the GOES Plume Viewer, focusing on date filtering functionality and animation timeline improvements.
Changes:
Date Picker Temporal Extent Restrictions (Commit: 0eb8684)
Implemented dynamic calculation of min/max dates from regions data and added constraints to DatePicker components to grey out dates outside the available data range. Added reset functionality to restore date range when the home button is clicked, preventing users from selecting dates with no available data.
Animation Timeline First Plume Display Fix (Commit: e51e64f)
Resolved issue where the first plume would disappear when dragging the animation slider to the beginning by moving the initial plume display call outside of the timeline onStart handler, ensuring proper rendering before timeline initialization.
Measurement Tool Icon Visibility Fix (Commit: 140ccdf)
Fixed ruler icon turning white and blending with button background when selected by replacing the undefined CSS variable with the correct color variable, ensuring proper contrast between icon and button background.
Animation Replay Button Fix (Commit: 005d427)
Fixed replay button incorrectly restarting the animation from the middle of the timeline instead of the beginning. The issue was caused by the mapboxgl-timeline library passing a string value to the Date constructor. Applied a monkey patch to correctly parse the slider's minimum value as a number, and updated the onStart callback to properly reset animation state and clear all buffered layers.
PR is made on the timeline library too. ref