Skip to content

fix: handle invalid stdout messages #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

fix: handle invalid stdout messages #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "uipath-mcp"
version = "0.0.94"
version = "0.0.95"
description = "UiPath MCP SDK"
readme = { file = "README.md", content-type = "text/markdown" }
requires-python = ">=3.11"
Expand Down
38 changes: 31 additions & 7 deletions src/uipath_mcp/_cli/_runtime/_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@

from mcp import StdioServerParameters, stdio_client
from mcp.shared.message import SessionMessage
from mcp.types import JSONRPCError, JSONRPCMessage, JSONRPCRequest, JSONRPCResponse
from mcp.types import (
ErrorData,
JSONRPCError,
JSONRPCMessage,
JSONRPCRequest,
JSONRPCResponse,
)
from opentelemetry import trace
from uipath import UiPath

Expand All @@ -31,7 +37,8 @@ def __init__(self, server_config: McpServer, session_id: str):
self._run_task = None
self._message_queue = asyncio.Queue()
self._active_requests: Dict[str, str] = {}
self._last_request_id: None
self._last_request_id = None
self._last_message_id = None
self._uipath = UiPath()
self._mcp_tracer = McpTracer(tracer, logger)
self._server_stderr_output: Optional[str] = None
Expand Down Expand Up @@ -122,11 +129,17 @@ async def _run_server(self, server_params: StdioServerParameters) -> None:
session_message = None
try:
session_message = await self._read_stream.receive()
if isinstance(session_message, Exception):
logger.error(f"Received error: {session_message}")
continue
message = session_message.message
# For responses, determine which request_id to use
if self._is_response(message):
message_id = self._get_message_id(message)
if message_id and message_id in self._active_requests:
if (
message_id
and message_id in self._active_requests
):
# Use the stored request_id for this response
request_id = self._active_requests[message_id]
# Send with the matched request_id
Expand All @@ -140,7 +153,9 @@ async def _run_server(self, server_params: StdioServerParameters) -> None:
)
else:
# For non-responses, use the last known request_id
await self._send_message(message, self._last_request_id)
await self._send_message(
message, self._last_request_id
)
except Exception as e:
if session_message:
logger.info(session_message)
Expand All @@ -149,12 +164,20 @@ async def _run_server(self, server_params: StdioServerParameters) -> None:
exc_info=True,
)
await self._send_message(
JSONRPCError(
code=-32000,
message=f"Error processing message: {session_message} {e} ",
JSONRPCMessage(
root=JSONRPCError(
jsonrpc="2.0",
# Use the last known message id for error reporting
id=self._last_message_id,
error=ErrorData(
code=-32000,
message=f"Error processing message: {e}",
),
)
),
self._last_request_id,
)
continue
finally:
# Cancel the consumer when we exit the loop
consumer_task.cancel()
Expand Down Expand Up @@ -267,6 +290,7 @@ async def _get_messages_internal(self, request_id: str) -> None:
if self._is_request(json_message):
message_id = self._get_message_id(json_message)
if message_id:
self._last_message_id = message_id
self._active_requests[message_id] = request_id
with self._mcp_tracer.create_span_for_message(
json_message,
Expand Down