Skip to content

Commit 6584c24

Browse files
jamesmcgillekcoh
andauthored
FIX: BindingSyntax WithInteraction() was incorrectly using processors. (#1777)
* FIX: Fix for WithInteraction() which appeared to be broken * Add Changelog entry --------- Co-authored-by: Håkan Sidenvall <[email protected]>
1 parent 27358d4 commit 6584c24

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Packages/com.unity.inputsystem/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ however, it has to be formatted properly to pass verification tests.
3434
- Fixed an issue where undoing deletion of Action Maps did not restore Actions correctly.
3535
- Fixed case [ISXB-628](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-628) (OnIMECompositionChange does not return an empty string on accept when using Microsoft IME) by clarifying expectations and intended usage for the IME composition change event.
3636
- Fixed case [ISX-1668] (The Profiler shows incorrect data and spams the console with "Missing Profiler.EndSample" errors when there is an Input System Component in Scene).
37+
- Fix for BindingSyntax `WithInteraction()` which was incorrectly using processors.
3738

3839
## [1.8.0-pre.1] - 2023-09-04
3940

Packages/com.unity.inputsystem/InputSystem/Actions/InputActionSetupExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1245,9 +1245,9 @@ public BindingSyntax WithInteraction<TInteraction>()
12451245
if (!valid)
12461246
throw new InvalidOperationException("Accessor is not valid");
12471247

1248-
var interactionName = InputProcessor.s_Processors.FindNameForType(typeof(TInteraction));
1248+
var interactionName = InputInteraction.s_Interactions.FindNameForType(typeof(TInteraction));
12491249
if (interactionName.IsEmpty())
1250-
throw new NotSupportedException($"Type '{typeof(TInteraction)}' has not been registered as a processor");
1250+
throw new NotSupportedException($"Type '{typeof(TInteraction)}' has not been registered as a interaction");
12511251

12521252
return WithInteraction(interactionName);
12531253
}

0 commit comments

Comments
 (0)