FIX: JsonParser / ParseStringValue now creates unescaped strings #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings to improve comparison performance when activating devices.
…e improvement (ISX-1450)
AlexTyrer
changed the title
…n TryMatchDisconnectedDevice o Native deviceDescriptor / capabilities field is escaped Json string o Managed description.capabilities string is non-escaped Json string o Use temporary escaped Json string for quicker comparison
o Move MakeEscapedJsonString functionality to its own function o Devices_RemovingAndReaddingDevice_DoesNotAllocateMemory now expects a single (string) GC allocation per call to ReportNewInputDevice o Fix for PrimitiveValue ToBoolean for double type (logic was inverted)
ekcoh
approved these changes
Aug 27, 2024
| return !Mathf.Approximately(m_FloatValue, default); | ||
| case TypeCode.Double: | ||
| return NumberHelpers.Approximately(m_DoubleValue, default); | ||
| return !NumberHelpers.Approximately(m_DoubleValue, default); |
There was a problem hiding this comment.
Yes, I spotted a bug we didn't even know we had!
ekcoh
reviewed
Aug 27, 2024
|
|
||
| ### Changed | ||
| - Use `ProfilerMarker` instead of `Profiler.BeginSample` and `Profiler.EndSample` when appropriate to enable recording of profiling data. | ||
| - Improved performance of disconnected device activation (ISX-1450) |
There was a problem hiding this comment.
I think this could live under ### Fixed since it's not really a changed behavior, right?
ekcoh
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comparing escaped and non-escaped strings is very slow - this happens when devices are deactivated/reactivated such as when the Quest2 headset and controllers enter and awake from sleep mode.
The high cost comes from having to compare each string character-by-character (skipping '' escapes) each time entering the C# runtime to perform System.Globalization.ToUpperInvariant.
Changes made
This change to TryMatchDisconnectedDevice() means that any parsed strings that contain escape characters are converted to non-escaped strings for much quicker comparison.
This saves approximately 0.5ms / frame when an Oculus headset or controller is reactivated.
Testing
Local testing with the Quest2 headset and controllers using Superluminal to capture the cost of device awakening.
Risk
We allocate a temporary string where before we did not.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: