FIX: Fixed multiple interactions on composite bindings (ISXB-619) #2000
Conversation
bmalrat
force-pushed
the
isxb-619-fix-tap-interaction-on-composite-binding
branch
from
b1244fa to
7a8dcc2
Compare
|
Will check this |
| Assert.That(canceledInteraction, Is.Null); | ||
| Assert.That(performedInteraction, Is.Null); | ||
|
|
||
| currentTime = 0.01; |
There was a problem hiding this comment.
For maintainability maybe use defaultTapTime? https://docs.unity3d.com/Packages/[email protected]/api/UnityEngine.InputSystem.InputSettings.html#UnityEngine_InputSystem_InputSettings_defaultTapTime
| performedInteraction = null; | ||
|
|
||
| // Long PressRelease AW trigger a hold | ||
| currentTime = 1; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Also fine as is since I would image default would never go that far
There was a problem hiding this comment.
in the test I initialized hold with hold(duration=2) I will add some comments
| // Ensure that https://jira.unity3d.com/browse/ISXB-619 regress | ||
| [Test] | ||
| [Category("Actions")] | ||
| public void Actions_WithCompositeWithMultipleInteractions_Works() |
There was a problem hiding this comment.
Thanks for writing a test with this quite elaborate sequence which I believe is key to avoid regressive behaviour when there are actually interdependencies between the interaction patterns
| // the action. If we go back to waiting here, then the system can't tell that there's another interaction | ||
| // ready to perform (in fact, that has already performed). | ||
| if (newPhase == InputActionPhase.Performed && | ||
| actionIndex != -1 && !actionStates[actionIndex].isPerformed && |
There was a problem hiding this comment.
Minor: Would prefer actionIndex >= 0 for readability.
There was a problem hiding this comment.
changed to use the kInvalidIndex
|
Please check the iOS CI failures |
bmalrat
deleted the
isxb-619-fix-tap-interaction-on-composite-binding
branch
3 participants
Description
When composite bindings contains multiple interactions the interaction on each sub part could enter a bad state and stop functioning.
The user use case with tap,hold on WASD. stop working after a hold of WD. All subsequent press will be a hold even if it was a tap.
Changes made
Testing
new test + local testing of the customer project
Risk
Please describe the potential risks of your changes for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: