FIX: Action Maps contextual menu in Action Editor UI that could display unrelated items. #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay unrelated items.
ritamerkl
approved these changes
Sep 19, 2024
| _ = new ContextualMenuManipulator(menuEvent => | ||
| var manipulator = new ContextualMenuManipulator(menuEvent => | ||
| { | ||
| //menuEvent.menu.ClearItems(); |
There was a problem hiding this comment.
ho good catch thanks
| ### Fixed | ||
| - Fixed Multiple interactions could breaks on Composite Binding. [ISXB-619](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-619) | ||
| - Fixed memory leak when the OnScreenStick component was destroyed [ISXB-1070](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1070). Contribution by [LukeUnityDev](https://github.com/LukeUnityDev). | ||
| - Fixed Action Maps contextual menu in Action Editor UI that could display unrelated items. |
There was a problem hiding this comment.
the only part I am stumbling over is the "could", but technically that's not wrong.
bmalrat
force-pushed
the
fix-for-action-maps-contextual-menu
branch
from
ffa537e to
eb3996f
Compare
ritamerkl
approved these changes
Sep 19, 2024
Pauliusd01
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contextual menu of Action maps contain wrong entries
Changes made
Fixed the contextual registration that registered on each item without unregistering.
Testing
local testing
Risk
Please describe the potential risks of your changes for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: