Skip to content

Conversation

bmalrat
Copy link
Collaborator

@bmalrat bmalrat commented Sep 20, 2024

Description

When closing a dropdown field the ui module still reference a deleted object and try to use it with a null propagation operator which is not compatible with unity object https://github.com/microsoft/Microsoft.Unity.Analyzers/blob/main/doc/UNT0008.md

Changes made

Changed the access to use the bool operator check

Testing

tested with customer project

Risk

Please describe the potential risks of your changes for the reviewers.

Checklist

Before review:

  • [ X] Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

Copy link
Collaborator

@benoitalain benoitalain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmalrat bmalrat merged commit 008f573 into develop Sep 20, 2024
77 checks passed
@bmalrat bmalrat deleted the isxb-1081-fix-missingreferenceexception-errors branch September 20, 2024 16:01
Copy link
Collaborator

@lyndon-unity lyndon-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you.

@kamyker
Copy link

kamyker commented Sep 24, 2024

Thanks, couldn't use Unity 6 without this fix (upgraded from 2022).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants