FIX: Fixed wrong Display Index value for touchscreen events (ISXB-1101)
#2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmalrat
changed the title
Display Index value for touchscreen events (ISXB-1101)Display Index value for touchscreen events (ISXB-1101)
lyndon-unity
reviewed
Oct 2, 2024
| [InputControl(name = "pressure", useStateFrom = "primaryTouch/pressure")] | ||
| [InputControl(name = "radius", useStateFrom = "primaryTouch/radius")] | ||
| [InputControl(name = "press", useStateFrom = "primaryTouch/phase", layout = "TouchPress", synthetic = true, usages = new string[0])] | ||
| [InputControl(name = "displayIndex", useStateFrom = "primaryTouch/displayIndex", format = "BYTE")] // added format to override the Pointer's USHT value |
There was a problem hiding this comment.
Looks like a good fix. Thanks for adding the comment to say why format is added to make sure its not removed in future refactorings.
| base.FinishSetup(); | ||
|
|
||
| primaryTouch = GetChildControl<TouchControl>("primaryTouch"); | ||
| displayIndex = primaryTouch.displayIndex; |
There was a problem hiding this comment.
Why is this line removed ?
I'd suggest Hakan review this PR since he added this code:
#1623
There was a problem hiding this comment.
It's not needed any more since I added the other attributes which override display index and use the state from the primary touch.
Like other overridden values like pressure Wich are already mapped in the base Pointer class.
stefanunity
approved these changes
Oct 4, 2024
lyndon-unity
approved these changes
Oct 9, 2024
ekcoh
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When reading the
Display Indexof touch event is add 2048 to the value.https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1101
It uses the inherited pointer's
ushortdefinition but for touchscreen it's abyte.Changes made
Fixed the mapping of the
Display Indexfield that doesn't match for touch event.Testing
local testing on multiple screen
Risk
Please describe the potential risks of your changes for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: