Skip to content

Conversation

@Pauliusd01
Copy link
Collaborator

Description

Please fill this section with a description what the pull request is trying to address.

Changes made

Please write down a short description of what changes were made.

Testing

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Risk

Please describe the potential risks of your changes for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@Pauliusd01 Pauliusd01 changed the title Update UITests.cs CHANGE: Disable some display index tests on android Oct 17, 2024
Copy link
Collaborator

@jamesmcgill jamesmcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to remove that extra #endif

#if UNITY_TVOS || UNITY_ANDROID
[Ignore("Failing on TVOS & Android https://jira.unity3d.com/browse/ISX-2029")]
#endif
#endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra #endif is here

@Pauliusd01 Pauliusd01 merged commit 0c6e227 into develop Oct 17, 2024
3 of 77 checks passed
@Pauliusd01 Pauliusd01 deleted the disable-displayindex-tests-on-android branch October 17, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants