-
Notifications
You must be signed in to change notification settings - Fork 328
FIX: ISXB-1153 fix exception on paste to empty actionmap list #2042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Getting an "Invalid action index to insert bindings before." error when pasting an action to an empty action list (does not occur on stable) 1730361545.TrunkInputSystem_-_MouseVisualizer_-_Windows._Mac.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, found 2 more paste related bugs but they're not regressions so will file those separately. Checked: cut/copy pasting maps, actions and bindings between assets when they're empty, have assets, when the thing I'm cutting is the last on the list, when the actions/maps aren't saved yet in either asset (all with shortcuts and context menu). Also, undo/redo workflow and auto save behaviour.
…ol` and pointer based schemes (ISXB-656) (#2023)
…se user action (case ISXB-1131) (#2044) * [Input System] The "Add Control Scheme..." popup now requires explicit Save/Close user action (case ISXB-1131) o Previously clicking outside the popup window (anywhere in the editor) would close the popup window. o This would leave a new blank (unnamed, orphaned) control scheme populating the UI - this was confusing. o Now this popup will persist until the user explictly chooses to Save or Cancel. * [Input System] Added CHANGELOG entry for "Add Control Scheme..." popup fix (case ISXB-1131) * [Input System] Fix typo in CHANGELOG entry - removed extraneous final closing parenthesis. * [Input System] Licensing failure - try limiting to version 2021.3.45f
7107a9f to
6c053a5
Compare
Description
Fixed an exception when pasting an action map into an empty action map list. ISXB-1150
Testing status & QA
local package tests succeeded.
Overall Product Risks
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: