Skip to content

Conversation

@smnwttbr
Copy link
Collaborator

Description

Fixed an exception when pasting an action map into an empty action map list. ISXB-1150

Testing status & QA

local package tests succeeded.

Overall Product Risks

  • Complexity: low
  • Halo Effect: small

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@Pauliusd01
Copy link
Collaborator

Getting an "Invalid action index to insert bindings before." error when pasting an action to an empty action list (does not occur on stable)

1730361545.TrunkInputSystem_-_MouseVisualizer_-_Windows._Mac.mp4

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating status

@smnwttbr smnwttbr requested a review from Pauliusd01 November 6, 2024 05:37
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, found 2 more paste related bugs but they're not regressions so will file those separately. Checked: cut/copy pasting maps, actions and bindings between assets when they're empty, have assets, when the thing I'm cutting is the last on the list, when the actions/maps aren't saved yet in either asset (all with shortcuts and context menu). Also, undo/redo workflow and auto save behaviour.

bmalrat and others added 2 commits November 11, 2024 11:05
…se user action (case ISXB-1131) (#2044)

* [Input System] The "Add Control Scheme..." popup now requires explicit Save/Close user action (case ISXB-1131)

o Previously clicking outside the popup window (anywhere in the editor) would close the popup window.

o This would leave a new blank (unnamed, orphaned) control scheme populating the UI - this was confusing.

o Now this popup will persist until the user explictly chooses to Save or Cancel.

* [Input System] Added CHANGELOG entry for "Add Control Scheme..." popup fix (case ISXB-1131)

* [Input System] Fix typo in CHANGELOG entry - removed extraneous final closing parenthesis.

* [Input System] Licensing failure - try limiting to version 2021.3.45f
@smnwttbr smnwttbr force-pushed the isxb-1153-paste-to-empty-maplist branch from 7107a9f to 6c053a5 Compare November 11, 2024 03:06
@smnwttbr smnwttbr merged commit 6331849 into develop Nov 12, 2024
77 checks passed
@smnwttbr smnwttbr deleted the isxb-1153-paste-to-empty-maplist branch November 12, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants