Skip to content

Conversation

@AlexTyrer
Copy link
Contributor

@AlexTyrer AlexTyrer commented Nov 12, 2024

Description

The PasteBindingsFromClipboard() method was not checking that there might not even be any bindings when querying the (possibly empty) action map - this could lead to a NullReferenceException in the console.

Adding a null check and early return fixes this - it's already done like this in PasteActionsFromClipboard()

Testing status & QA

Local testing / automated tests.

Overall Product Risks

Vanishingly small - just a null check and early return.

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

None in particular.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

…case ISXB-1180)

o Ensure PasteBindingsFromClipboard() checks for null bindingsArray like PasteActionsFromClipboard() does
@AlexTyrer AlexTyrer requested a review from ritamerkl November 12, 2024 16:37
Copy link
Collaborator

@ritamerkl ritamerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AlexTyrer AlexTyrer merged commit b0478f0 into develop Nov 13, 2024
80 checks passed
@AlexTyrer AlexTyrer deleted the isxb-1180/fix-paste-bindings-from-clipboard branch November 13, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants