Skip to content

Conversation

brice-gros
Copy link
Collaborator

Description

Make displayIndex usable for PenState.

Changes made

Use the displayIndex from PenState to get the target display

Testing

Tested on Android 14

Risk

PenState not working on non-Android platform

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@brice-gros brice-gros changed the title Use penstate display index FIX: Make displayIndex usable for PenState Nov 21, 2024
Copy link
Collaborator

@stefanunity stefanunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous PR #1976 (which was closed since we can't get merges from forks):

-I don't have an android with a pen, even less the exact device Brice has
-I tested some pen and touch/pointer input on Windows touch screen and wacom + pen
-nothing bad happened

Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ideally would have an automated test case with generated Pen data, but ok as is.

@stefanunity stefanunity merged commit fcb4731 into develop Dec 12, 2024
77 checks passed
@stefanunity stefanunity deleted the use-penstate-displayIndex branch December 12, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants