-
Notifications
You must be signed in to change notification settings - Fork 331
FIX: Make displayIndex usable for PenState #2057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stefanunity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous PR #1976 (which was closed since we can't get merges from forks):
-I don't have an android with a pen, even less the exact device Brice has
-I tested some pen and touch/pointer input on Windows touch screen and wacom + pen
-nothing bad happened
ekcoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ideally would have an automated test case with generated Pen data, but ok as is.
Description
Make displayIndex usable for PenState.
Changes made
Use the displayIndex from PenState to get the target display
Testing
Tested on Android 14
Risk
PenState not working on non-Android platform
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: