Skip to content

Conversation

@stefanunity
Copy link
Collaborator

Description

We need to move package pack, verification and publishing to PackageWorks so we can publish ourselves moving forward.

  • installed Wrench tooling
  • customized jobs to fit our package
  • generated yml files

Testing status & QA

  • All the new jobs are green
  • packed package has the same contents as if packed with our old job

Overall Product Risks

Very little risk, all the old jobs still exist and we can release with them until RM stops us.

  • Complexity: low
  • Halo Effect: none

Comments to reviewers

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

Copy link
Collaborator

@jfreire-unity jfreire-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!
If releasing works, maybe a intro about this to team would be great. Or just pointing in the right direction of internal documentation :)

@@ -0,0 +1,149 @@
# Description: This script is used to onboard a project onto Wrench
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curioisity: when is this Python script called in the process?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is called at the very beginning and you can then delete it

]
},
"publishing_job": ".yamato/wrench/promotion-jobs.yml#publish_inputsystem",
"branch_pattern": "ReleaseSlash",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this is true? Our releases have always been tagged commits in the stable branch. Unless we are changing this now or this is some other "branch pattern." I'm fine with either; I just want to surface this in case it becomes a problem.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a new branch called release/1.X and we need to follow this pattern says RM.
I'll update the release manual and it shouldn't be a big change for us.

@stefanunity stefanunity merged commit daad73d into develop Nov 25, 2024
77 checks passed
@stefanunity stefanunity deleted the packageworks-setup branch November 25, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants