-
Notifications
You must be signed in to change notification settings - Fork 328
NEW: Add Packageworks setup to selfserve publishing #2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
If releasing works, maybe a intro about this to team would be great. Or just pointing in the right direction of internal documentation :)
Tools/CI/onboard.py
Outdated
| @@ -0,0 +1,149 @@ | |||
| # Description: This script is used to onboard a project onto Wrench | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curioisity: when is this Python script called in the process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is called at the very beginning and you can then delete it
| ] | ||
| }, | ||
| "publishing_job": ".yamato/wrench/promotion-jobs.yml#publish_inputsystem", | ||
| "branch_pattern": "ReleaseSlash", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if this is true? Our releases have always been tagged commits in the stable branch. Unless we are changing this now or this is some other "branch pattern." I'm fine with either; I just want to surface this in case it becomes a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a new branch called release/1.X and we need to follow this pattern says RM.
I'll update the release manual and it shouldn't be a big change for us.
Description
We need to move package pack, verification and publishing to PackageWorks so we can publish ourselves moving forward.
Testing status & QA
Overall Product Risks
Very little risk, all the old jobs still exist and we can release with them until RM stops us.
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: