-
Notifications
You must be signed in to change notification settings - Fork 328
FIX: Set active input handler to InputManager when package is removed (ISXB-675) #2059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks for dealing with this. Code looks fine to me.
I only made some nitpick suggestions in some comments text and the dialog text. Happy to approve if QA goes well.
Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPackageControl.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPackageControl.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPackageControl.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPackageControl.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: João Freire <[email protected]>
Co-authored-by: João Freire <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving only if the last commit is fixed. Here's what I checked:
Removing the IS package with each of the 3 backend settings.
Updating the package instead of removing it (it did not mess with the backend as expected)
Removing the package through the manifest file while the Editor is open (the backend was changed correctly)
Removing the package through the manifest file while the Editor is closed (the backend did not change but that seems to be known)

Description
This change aims to fix this bug ticket, where the active input handling options can be set independently of the presence of the package.
Now the input handling is set to InputManager once the package is removed. The second part of this fix lands on trunk, where setting the input handling to "InputSystem" or "Both" can only be done when the package is installed.
The fix is available vor Unity version 2020.2 and above, for the sake of the PackageManager package register event being only available from 2020.2 and above.
Testing status & QA
Manual testing.
Overall Product Risks
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: