Skip to content

Conversation

@tspiller
Copy link
Collaborator

@tspiller tspiller commented Dec 6, 2024

Description

Secondary fix to ArgumentOutOfRangeException error when creating a new ControlScheme as the device index needs to be explicitly set so the correct 'All Devices' device is shown.

Testing status & QA

Local testing

Overall Product Risks

Complexity: 0
Halo Effect: 0

Comments to reviewers

CHANGELOG was updated in #2047 with the original bug so added this as an internal change.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@tspiller tspiller requested review from Pauliusd01 and ekcoh December 6, 2024 11:49
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, device selection is reset correctly now when creating new schemes, changing them, renaming, or closing and reopening the window

@tspiller tspiller marked this pull request as ready for review December 9, 2024 14:38
@tspiller tspiller merged commit eca97b8 into develop Dec 9, 2024
77 checks passed
@tspiller tspiller deleted the isxb-1129-new-control-scheme-device-index branch December 9, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants