Skip to content

FIX: Select dropdown menu for Path in Input Actions Editor from any position in Path button #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2025
Merged

FIX: Select dropdown menu for Path in Input Actions Editor from any position in Path button #2114

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e1e589
Fit LabelRect width to label and recalculate text and button position…
tspiller Jan 27, 2025
7c0380d
Update CHANGELOG.md
tspiller Jan 27, 2025
1307669
Merge branch 'develop' into isxb-1309-calcsize-labels-inputcontrolpat…
tspiller Jan 29, 2025
3af27b2
Merge branch 'develop' into isxb-1309-calcsize-labels-inputcontrolpat…
tspiller Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ however, it has to be formatted properly to pass verification tests.
- Fixed GamepadButton.LeftTrigger and GamepadButton.RightTrigger enum values not matching displayed dropdown values in editor when using GamepadButtonPropertyDrawer [ISXB-1270](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1270).
- Fixed an issue causing InvalidOperationException when entering playmode with domain reload disabled. [ISXB-1208](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1208).
- Fixed an issue where compiling Addressables with Input System package present would result in failed compilation due to `IInputAnalytic.TryGatherData` not being defined [ISXB-1203](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1203).
- Fixed an issue where dropdown menu for Path in Input Actions Editor could not be selected from any button position. [ISXB-1309](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1309)


## [1.12.0] - 2025-01-15

Expand Down
9 changes: 4 additions & 5 deletions Packages/com.unity.inputsystem/InputSystem/Editor/ControlPicker/InputControlPathEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,17 @@ public void OnGUI(Rect rect, GUIContent label = null, SerializedProperty propert

var lineRect = rect;
var labelRect = lineRect;
labelRect.width = EditorGUIUtility.labelWidth;
labelRect.width = EditorStyles.label.CalcSize(pathLabel).x + 20; // Fit to label with some padding
EditorGUI.LabelField(labelRect, pathLabel);
lineRect.x += labelRect.width;
lineRect.width -= labelRect.width;

var bindingTextRect = lineRect;
var editButtonRect = lineRect;

var bindingTextRectOffset = 80;
bindingTextRect.width += bindingTextRectOffset;
bindingTextRect.x -= bindingTextRectOffset + 20;
editButtonRect.x = bindingTextRect.x + bindingTextRect.width; // Place it directly after the textRect
bindingTextRect.x = labelRect.x + labelRect.width; // Place directly after labelRect
editButtonRect.x += lineRect.width - 20; // Place at the edge of the window to appear after bindingTextRect
bindingTextRect.width = editButtonRect.x - bindingTextRect.x; // bindingTextRect fills remaining space between label and editButton
editButtonRect.width = 20;
editButtonRect.height = 15;

Expand Down