Skip to content

FIX: Fixed an issue where compiling Addressables with Input System package present would result in failed compilation due to IInputAnalytic.TryGatherData not being defined. #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2025
Merged

FIX: Fixed an issue where compiling Addressables with Input System package present would result in failed compilation due to IInputAnalytic.TryGatherData not being defined. #2115

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1341226
FIX: - Fixed an issue where compiling Addressables with Input System …
ekcoh Jan 27, 2025
4e02346
Fixed comment and inverted #if based on review comments
ekcoh Jan 28, 2025
209716f
Merge branch 'develop' into isxb-1203-analytics-and-addressables
ekcoh Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ however, it has to be formatted properly to pass verification tests.
### Fixed
- Fixed an issue where the prompt to enable the InputSystem backends would interrupt the import of large assets.
- Fixed Cut Mode for Action Maps and Actions to make renaming disabled. [ISXB-1155](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1155)

- Fixed an issue where compiling Addressables with Input System package present would result in failed compilation due to `IInputAnalytic.TryGatherData` not being defined [ISXB-1203](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1203).

## [1.12.0] - 2025-01-15

Expand Down
5 changes: 4 additions & 1 deletion Packages/com.unity.inputsystem/InputSystem/InputAnalytics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ public interface IInputAnalytic
{
InputAnalyticInfo info { get; } // May be removed when only supporting 2023.2+ versions

#if !UNITY_2023_2_OR_NEWER
#if UNITY_EDITOR && UNITY_2023_2_OR_NEWER
// ISXB-1203 TryGatherData is defined by base. Note that UNITY_EDITOR is not defined when
// compiling addressables even when running in editor.
#else
// Conditionally mimic UnityEngine.Analytics.IAnalytic
bool TryGatherData(out IInputAnalyticData data, out Exception error);
#endif // !UNITY_2023_2_OR_NEWER
Expand Down
Loading