Skip to content

Conversation

@smnwttbr
Copy link
Collaborator

@smnwttbr smnwttbr commented Feb 5, 2025

Description

A check for an existing and dirty asset was added to the OpenWindow(asset) method. If a dirty asset is loaded, a dialog is presented allowing the user to save changes, cancel the operation or discard changes and continue.

Testing status & QA

Package tests.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@smnwttbr smnwttbr marked this pull request as ready for review February 5, 2025 05:42
@smnwttbr smnwttbr requested a review from Pauliusd01 February 6, 2025 04:18
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some CI failures so might want to check those out, otherwise lgtm. Checked opening a different action window with both manual save/auto save options after changing schemes,maps,actions,bindings, etc.

@Secticide Secticide self-assigned this Mar 21, 2025
@Secticide Secticide force-pushed the isxb-1343-show-dialog-for-unsaved-changes branch from 5e94786 to 88b4df9 Compare March 21, 2025 14:00
@Secticide Secticide removed the request for review from stefanunity March 25, 2025 09:56
@Secticide Secticide force-pushed the isxb-1343-show-dialog-for-unsaved-changes branch from 88b4df9 to 2677b68 Compare March 25, 2025 14:55
@Secticide
Copy link
Collaborator

I noticed my previous change #2149 added a changelog entry to the previous release, fixed up as part of 2677b68.

@Secticide Secticide merged commit 5b82ede into develop Mar 26, 2025
110 checks passed
@Secticide Secticide deleted the isxb-1343-show-dialog-for-unsaved-changes branch March 26, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants