Skip to content

Conversation

@ekcoh
Copy link
Collaborator

@ekcoh ekcoh commented Feb 10, 2025

Description

Fix for a bug (ISXB-1531) in parameter UITK editor which wouldn't update its visual representation if setting default values would be changed while the editor is still open. Additionally did some slight refactoring to eliminate some redundant code.

I did not attempt to fix the missing tri-state representation which should really be done to make this implementation better.

Testing status & QA

Tested manually by changing settings default values and toggling defaults on/off.

Overall Product Risks

  • Complexity: Small
  • Halo Effect: Small

Comments to reviewers

Recommend testing different scenarios of switching settings, changing default etc with asset editor open.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@ekcoh ekcoh merged commit 4f0179e into develop Feb 12, 2025
94 checks passed
@ekcoh ekcoh deleted the isxb-1351-parameter-editor-default-value-fix branch February 12, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants