-
Notifications
You must be signed in to change notification settings - Fork 329
FIX: Prevent errors on certain platforms #2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0b96784 to
e69a4a2
Compare
aceunity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding us back in to remove the error.
ekcoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to approve this since very small and tidy, but I just want to emphasise that its very odd to me that the Input System contains such a list at all. Shouldn't we strive to get rid of this and let the platform itself report this as a capability via IOCTL?
Agreed, the intent behind was to get this in quickly with the deprecation of the InputManager and change to InputSystem for templates, since platforms with the need of an extra extension would just silently fail. I think to implement this into the platforms would be the better, cleaner way - but like I said, with the pressing need at that time it wasn't considered an option. |
Aha, I see. I thought this list was something older and I wasn't aware of it being something we added lately, guess I have suppressed that memory. Regardless, since this is internal we can get it removed. Lets get a ticket filed on this and discuss how we best get it in place. |
Description
https://jira.unity3d.com/browse/ISXB-1465
Add some platforms to the exclusion list for not requiring an extension package.
Testing status & QA
Manually tested fix on latest Editor, see ticket for reproduction steps.
Overall Product Risks
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: