Skip to content

FIX: Prevent errors on certain platforms #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2025
Merged

FIX: Prevent errors on certain platforms #2150

merged 3 commits into from
Mar 18, 2025

Conversation

@jamesmcgill
Copy link
Collaborator

@jamesmcgill jamesmcgill commented Mar 13, 2025 •
edited
Loading

Description

https://jira.unity3d.com/browse/ISXB-1465

Add some platforms to the exclusion list for not requiring an extension package.

Testing status & QA

Manually tested fix on latest Editor, see ticket for reproduction steps.

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Comments to reviewers

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@jamesmcgill jamesmcgill force-pushed the ISXB-1465-fix-nda-platform-error branch from 0b96784 to e69a4a2 Compare March 13, 2025 12:05
@jamesmcgill jamesmcgill requested a review from aceunity March 14, 2025 10:57
aceunity
aceunity approved these changes Mar 14, 2025
View reviewed changes
Copy link

@aceunity aceunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding us back in to remove the error.

@Pauliusd01 Pauliusd01 removed their request for review March 14, 2025 11:06
ekcoh
ekcoh approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to approve this since very small and tidy, but I just want to emphasise that its very odd to me that the Input System contains such a list at all. Shouldn't we strive to get rid of this and let the platform itself report this as a capability via IOCTL?

@ritamerkl
Copy link
Collaborator

ritamerkl commented Mar 17, 2025

I am going to approve this since very small and tidy, but I just want to emphasise that its very odd to me that the Input System contains such a list at all. Shouldn't we strive to get rid of this and let the platform itself report this as a capability via IOCTL?

Agreed, the intent behind was to get this in quickly with the deprecation of the InputManager and change to InputSystem for templates, since platforms with the need of an extra extension would just silently fail. I think to implement this into the platforms would be the better, cleaner way - but like I said, with the pressing need at that time it wasn't considered an option.

@ekcoh
Copy link
Collaborator

ekcoh commented Mar 17, 2025

I am going to approve this since very small and tidy, but I just want to emphasise that its very odd to me that the Input System contains such a list at all. Shouldn't we strive to get rid of this and let the platform itself report this as a capability via IOCTL?

Agreed, the intent behind was to get this in quickly with the deprecation of the InputManager and change to InputSystem for templates, since platforms with the need of an extra extension would just silently fail. I think to implement this into the platforms would be the better, cleaner way - but like I said, with the pressing need at that time it wasn't considered an option.

Aha, I see. I thought this list was something older and I wasn't aware of it being something we added lately, guess I have suppressed that memory. Regardless, since this is internal we can get it removed. Lets get a ticket filed on this and discuss how we best get it in place.

@jamesmcgill jamesmcgill merged commit 8fe669c into develop Mar 18, 2025
110 checks passed
@jamesmcgill jamesmcgill deleted the ISXB-1465-fix-nda-platform-error branch March 18, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekcoh ekcoh ekcoh approved these changes

@aceunity aceunity aceunity approved these changes

@ritamerkl ritamerkl ritamerkl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jamesmcgill @ritamerkl @ekcoh @aceunity