Skip to content

Conversation

@tspiller
Copy link
Collaborator

@tspiller tspiller commented Mar 27, 2025

Description

Manually providing a specified splitScreenIndex via JoinPlayer was not being passed correctly over to the PlayerInput during OnEnable.
This change takes the initially provided splitScreenIndex and sets it manually so it does not default to playerIndex.

Testing status & QA

Wrote one of the TODO tests for PlayerInput which fit the scenario - PlayerInput_CanSetUpSplitScreen_AndManuallyAllocatePlayersToScreens

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@tspiller tspiller marked this pull request as ready for review March 27, 2025 10:34
@tspiller tspiller requested review from Pauliusd01 and ekcoh March 27, 2025 10:34
[Category("PlayerInput")]
[Ignore("TODO")]
public void TODO_PlayerInput_CanSetUpSplitScreen_AndManuallyAllocatePlayersToScreens()
public void PlayerInput_CanSetUpSplitScreen_AndManuallyAllocatePlayersToScreens()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this very complex test :)

@tspiller tspiller merged commit 7c3ab2c into develop Apr 1, 2025
110 checks passed
@tspiller tspiller deleted the isxb-897-manually-allocate-splitscreenindex branch April 1, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants