Skip to content

Conversation

@K-Tone
Copy link
Collaborator

@K-Tone K-Tone commented Mar 28, 2025

Description

This aims to react to a user report where they complain about the two plus buttons actually not looking like buttons at all. Since they have no visible border and no background, they don't react to hovering, and neither they react to presses.

Here it's proposed to correct that by removing the transparent background while keeping the zero border config in, as that is deemed to look a bit better in this particular case.

b0d463d68c07f0b3ab1e2b0d2d09a4b4

Testing status & QA

Only affects UI, no behaviour change at the moment. Tested locally, check the gif above.

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@K-Tone K-Tone changed the title remove transparent background for the two plus buttons in the input a… FIX: Fixed the on hover behaviour of the two plus buttons in the Input Actions Editor window Mar 28, 2025
@K-Tone K-Tone requested review from Pauliusd01 and ekcoh March 28, 2025 13:58
@K-Tone K-Tone marked this pull request as ready for review March 28, 2025 13:59
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked light/dark mode themes in project wide actions window as well as custom ones. Now I don't know how design people feel about this plus button looking different from the others but to me it looks fine and changing all of them would probably be worse than not

Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a button I rather have users understanding the UI and then we can reiterate with UX representation if needed to make it look "nicer". Good fix with less customisation.

However I am afraid CHANGELOG.md has a conflict that needs to be resolved. Approving anyway assuming its fixed before landing this.

@K-Tone
Copy link
Collaborator Author

K-Tone commented Apr 2, 2025

I fixed the merge conflict, that was easy. Re-ran one instability, but the other one proves to be tricky - inputsystem - 6000.2 - macos won't rerun because of some unrelated editor installation issues:

unity-downloader-cli -u 6000.2 -c Editor --fast -- failed.

@K-Tone K-Tone added the bug Issues where existsing functionality misbehaves label Apr 2, 2025
@K-Tone K-Tone merged commit 70b54a3 into develop Apr 2, 2025
110 checks passed
@K-Tone K-Tone deleted the anthony/ixsb-1327-add-hover-input-actions branch April 2, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issues where existsing functionality misbehaves

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants