Skip to content

CHANGE: Removed isInBatchMode and isPaused from IInputRuntime (ISX-2323) #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025
Merged

CHANGE: Removed isInBatchMode and isPaused from IInputRuntime (ISX-2323) #2195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b492b5
INTERNAL: Removed isInBatchMode and isPaused from IInputRuntime
ekcoh Jun 18, 2025
49a7b06
Added missing namespace
ekcoh Jun 18, 2025
803c861
Merge branch 'develop' into isx-2323-minor-simplification-to-runtime
ekcoh Jun 24, 2025
c213906
Merge branch 'develop' into isx-2323-minor-simplification-to-runtime
ekcoh Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Packages/com.unity.inputsystem/InputSystem/IInputRuntime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,10 @@ internal unsafe interface IInputRuntime
void SendAnalytic(InputAnalytics.IInputAnalytic analytic);
#endif // UNITY_ANALYTICS || UNITY_EDITOR

bool isInBatchMode { get; }

#if UNITY_EDITOR
Action<PlayModeStateChange> onPlayModeChanged { get; set; }
Action onProjectChange { get; set; }
bool isInPlayMode { get; }
bool isPaused { get; }
bool isEditorActive { get; }

// Functionality related to the Unity Remote.
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.unity.inputsystem/InputSystem/InputManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ public bool runPlayerUpdatesInEditMode

private bool gameIsPlaying =>
#if UNITY_EDITOR
(m_Runtime.isInPlayMode && !m_Runtime.isPaused) || m_RunPlayerUpdatesInEditMode;
(m_Runtime.isInPlayMode && !UnityEditor.EditorApplication.isPaused) || m_RunPlayerUpdatesInEditMode;
#else
true;
#endif
Expand Down
2 changes: 1 addition & 1 deletion Packages/com.unity.inputsystem/InputSystem/InputSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3611,7 +3611,7 @@ private static void ShowRestartWarning()
{
if (!s_SystemObject.newInputBackendsCheckedAsEnabled &&
!EditorPlayerSettingHelpers.newSystemBackendsEnabled &&
!s_Manager.m_Runtime.isInBatchMode)
!Application.isBatchMode)
{
const string dialogText = "This project is using the new input system package but the native platform backends for the new input system are not enabled in the player settings. " +
"This means that no input from native devices will come through." +
Expand Down
4 changes: 0 additions & 4 deletions Packages/com.unity.inputsystem/InputSystem/NativeInputRuntime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,13 +293,9 @@ public float scrollWheelDeltaPerTick
get => NativeInputSystem.GetScrollWheelDeltaPerTick();
}
#endif

public bool isInBatchMode => Application.isBatchMode;

#if UNITY_EDITOR

public bool isInPlayMode => EditorApplication.isPlaying;
public bool isPaused => EditorApplication.isPaused;
public bool isEditorActive => InternalEditorUtility.isApplicationActive;

public Func<IntPtr, bool> onUnityRemoteMessage
Expand Down
3 changes: 0 additions & 3 deletions Packages/com.unity.inputsystem/Tests/TestFixture/InputTestRuntime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,11 +402,8 @@ public double currentTimeOffsetToRealtimeSinceStartup
}
}

public bool isInBatchMode { get; set; }

#if UNITY_EDITOR
public bool isInPlayMode { get; set; } = true;
public bool isPaused { get; set; }
public bool isEditorActive { get; set; } = true;
public Func<IntPtr, bool> onUnityRemoteMessage
{
Expand Down