Skip to content

Conversation

@jdiehlUnity
Copy link
Collaborator

@jdiehlUnity jdiehlUnity commented Jul 31, 2025

Description

Adds the InputDeviceCharacteristics enum into XRSupport so we don't depend on the type coming from the XR Module.
We already do the same thing here with the FeatureType enum.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@codecov-github-com
Copy link

codecov-github-com bot commented Jul 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2211   +/-   ##
========================================
  Coverage    68.11%   68.11%           
========================================
  Files          367      367           
  Lines        53603    53603           
========================================
  Hits         36512    36512           
  Misses       17091    17091           
Flag Coverage Δ
mac_2021.3_pkg 5.40% <ø> (ø)
mac_2022.3_pkg 5.18% <ø> (ø)
mac_6000.0_pkg 5.19% <ø> (ø)
mac_6000.1_pkg 5.19% <ø> (ø)
mac_6000.2_pkg 5.19% <ø> (ø)
mac_trunk_pkg 5.19% <ø> (ø)
win_2021.3_pkg 5.41% <ø> (ø)
win_2022.3_pkg 5.18% <ø> (ø)
win_6000.0_pkg 5.19% <ø> (ø)
win_6000.1_pkg 5.19% <ø> (ø)
win_6000.2_pkg 5.19% <ø> (ø)
win_trunk_pkg 5.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...utsystem/InputSystem/Plugins/XR/GenericXRDevice.cs 87.87% <ø> (ø)
...utsystem/InputSystem/Plugins/XR/XRLayoutBuilder.cs 91.81% <ø> (ø)
...ty.inputsystem/InputSystem/Plugins/XR/XRSupport.cs 41.83% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdiehlUnity jdiehlUnity marked this pull request as ready for review July 31, 2025 18:10
@jdiehlUnity jdiehlUnity closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants