FIX: out of range exception when pressing undo after creating and editing a new control scheme (ISXB-1607) #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by Undoing the creation of it via ctrl+z.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2237 +/- ##
===========================================
- Coverage 68.14% 68.11% -0.04%
===========================================
Files 367 367
Lines 53685 53713 +28
===========================================
+ Hits 36585 36586 +1
- Misses 17100 17127 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Darren-Kelly-Unity
changed the title
ekcoh
reviewed
Oct 6, 2025
| { | ||
| try | ||
| { | ||
| await Task.Delay(1); |
There was a problem hiding this comment.
This await Task.Delay(1) raises warning flags to me. What guarantees this is valid to execute 1 second from now?
- Why does it have to be delayed?
- It looks like this runs async but code being accessed do not seem to be thread safe?
- Is there a logical condition not based on time when this is valid to execute?
ekcoh
reviewed
Oct 6, 2025
|
|
||
| s_OnPasteCutElements.Add(this); | ||
|
|
||
| Undo.undoRedoPerformed += CheckForInvalidControlSchemeInOneFrame; |
There was a problem hiding this comment.
Maybe I am misunderstanding this PR/issue so I want to check whether this problem is if you undo text editing while in text editing mode? Such editing should not have been applied yet to any serializedProperty right or am I misunderstanding this issue?
ekcoh
reviewed
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You could cause multiple null or out of range exceptions if you press undo while editing a control scheme.
This is caused by undo causing the control scheme to be removed while you still have the edit window open.
Now the edit window will stay open until you interact with it, once you interact it will close & no exceptions are thrown anymore.
Ticket:
https://jira.unity3d.com/browse/ISXB-1607
Testing status & QA
Tested manually all the cases I could find until all exceptions were gone. There was multiple paths to create exceptions due to the asset being removed via undo.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: