Skip to content

Conversation

ekcoh
Copy link
Collaborator

@ekcoh ekcoh commented Sep 29, 2025

Description

The Input System root project states it has been saved with 2021.3.45f1, but develop is opened with this editor there is large diff on meta files and project files, likely due to being saved or generated with another editor version. This PR attempts to remedy this so the project diff should be nothing when opened with the associated/supported editor (No cross-grade).

Note that this PR currently do not contain re-generated assets such as scenes etc. This might also be needed.

Testing status & QA

I have just opened the project and checked it seems ok since I do not want to affect the project by switching scenes etc.

Overall Product Risks

Small

  • Complexity: Small
  • Halo Effect: Small

Comments to reviewers

Ideally this leads to less diff problems for ourselves and our users.

Need help to spot any files that should not be updated.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@ekcoh ekcoh marked this pull request as ready for review September 29, 2025 18:51
@codecov-github-com
Copy link

codecov-github-com bot commented Sep 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2247      +/-   ##
===========================================
- Coverage    76.70%   76.70%   -0.01%     
===========================================
  Files          465      465              
  Lines        87919    87919              
===========================================
- Hits         67442    67436       -6     
- Misses       20477    20483       +6     
Flag Coverage Δ
inputsystem_MacOS_2021.3 5.91% <ø> (ø)
inputsystem_MacOS_2021.3_project 78.05% <ø> (ø)
inputsystem_MacOS_2022.3 5.37% <ø> (ø)
inputsystem_MacOS_2022.3_project 74.58% <ø> (ø)
inputsystem_MacOS_6000.0 5.19% <ø> (ø)
inputsystem_MacOS_6000.0_project 76.50% <ø> (ø)
inputsystem_MacOS_6000.2 5.19% <ø> (ø)
inputsystem_MacOS_6000.2_project 76.50% <ø> (ø)
inputsystem_MacOS_6000.3 5.19% <ø> (ø)
inputsystem_MacOS_6000.3_project 76.50% <ø> (ø)
inputsystem_MacOS_6000.4 5.19% <ø> (ø)
inputsystem_MacOS_6000.4_project 76.50% <ø> (ø)
inputsystem_Ubuntu_2021.3 5.91% <ø> (ø)
inputsystem_Ubuntu_2021.3_project 77.96% <ø> (ø)
inputsystem_Ubuntu_2022.3 5.38% <ø> (ø)
inputsystem_Ubuntu_2022.3_project 74.39% <ø> (ø)
inputsystem_Ubuntu_6000.0 5.19% <ø> (ø)
inputsystem_Ubuntu_6000.0_project 76.32% <ø> (ø)
inputsystem_Ubuntu_6000.2 5.19% <ø> (ø)
inputsystem_Ubuntu_6000.2_project 76.32% <ø> (ø)
inputsystem_Ubuntu_6000.3 5.19% <ø> (ø)
inputsystem_Ubuntu_6000.3_project 76.31% <ø> (ø)
inputsystem_Ubuntu_6000.4 5.19% <ø> (ø)
inputsystem_Ubuntu_6000.4_project 76.31% <ø> (-0.01%) ⬇️
inputsystem_Windows_2021.3 5.91% <ø> (ø)
inputsystem_Windows_2021.3_project 78.20% <ø> (ø)
inputsystem_Windows_2022.3 5.37% <ø> (ø)
inputsystem_Windows_2022.3_project 74.72% <ø> (ø)
inputsystem_Windows_6000.0 5.19% <ø> (ø)
inputsystem_Windows_6000.0_project 76.64% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.2 5.19% <ø> (ø)
inputsystem_Windows_6000.2_project 76.64% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.3 5.19% <ø> (ø)
inputsystem_Windows_6000.3_project 76.64% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.4 5.19% <ø> (ø)
inputsystem_Windows_6000.4_project 76.64% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jfreire-unity jfreire-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a simple and much needed PR. Based on @Pauliusd01 comments in Slack, maybe even better would be to do it for 2022.3 since 2021.3 will be EoL in some days. But I'm fine approving this change already and leave it up to you!

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think It's better to do this with 2022.3. As 2021.3 end of life is in 16 days

@ekcoh
Copy link
Collaborator Author

ekcoh commented Oct 5, 2025

Closing this pull request and will update associated ticket to do the same effort but with 2022.3 after 2021.3 EoL

@ekcoh ekcoh closed this Oct 5, 2025
@ekcoh ekcoh reopened this Oct 5, 2025
@ekcoh
Copy link
Collaborator Author

ekcoh commented Oct 5, 2025

Will update this PR to use 2022.3 (LTS) instead and then rerequest review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants