-
Notifications
You must be signed in to change notification settings - Fork 329
FIX: Fix files saved with the wrong project editor (2021.3.45f1) #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2247 +/- ##
===========================================
- Coverage 76.70% 76.70% -0.01%
===========================================
Files 465 465
Lines 87919 87919
===========================================
- Hits 67442 67436 -6
- Misses 20477 20483 +6 Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a simple and much needed PR. Based on @Pauliusd01 comments in Slack, maybe even better would be to do it for 2022.3 since 2021.3 will be EoL in some days. But I'm fine approving this change already and leave it up to you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think It's better to do this with 2022.3. As 2021.3 end of life is in 16 days
Closing this pull request and will update associated ticket to do the same effort but with 2022.3 after 2021.3 EoL |
Will update this PR to use 2022.3 (LTS) instead and then rerequest review |
Description
The Input System root project states it has been saved with 2021.3.45f1, but
develop
is opened with this editor there is large diff on meta files and project files, likely due to being saved or generated with another editor version. This PR attempts to remedy this so the project diff should be nothing when opened with the associated/supported editor (No cross-grade).Note that this PR currently do not contain re-generated assets such as scenes etc. This might also be needed.
Testing status & QA
I have just opened the project and checked it seems ok since I do not want to affect the project by switching scenes etc.
Overall Product Risks
Small
Comments to reviewers
Ideally this leads to less diff problems for ourselves and our users.
Need help to spot any files that should not be updated.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: