FIX: ISXB-1718 Corrections to not generate warnings on Unity 6.3b05.

[ekcoh]

Description

Changes to avoid generating warnings when using Unity 6.3b05:

• Changed constraint for previous warning fix (altering previous fix by @K-Tone in FIX: Address warnings that happened with Unity 6.4 #2233)
• Updated code generator for precompiled layouts and regenerated layouts to suppress warnings about deprecated code. It makes little sense to generate these warnings from source that is auto-generated and not caused by the user.

Testing status & QA

Checked that there are no warnings for 6.3. Checked Unity manual regarding which version supports what.

Overall Product Risks

• Complexity: Small
• Halo Effect: Small

Comments to reviewers

Should confirm that this doesn't generate warnings on Unity 6.2, 6.1 or 6.0 or 2023.3.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

After merge:

• Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

[u-pr-agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪ The PR contains small, consistent changes across a few files, primarily adjusting Unity version compatibility defines and suppressing warnings in generated code.

🏅 Score: 95 The PR effectively addresses compatibility warnings with Unity 6.3 by correctly adjusting version-specific compilation directives and suppressing warnings in auto-generated code, with only a minor outdated comment.

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Outdated Comment The comment on line 3698 refers to a migration in "Unity 6.4", but the associated preprocessor directive was updated to UNITY_6000_3_OR_NEWER. The comment should be updated to reflect this change for consistency. // We have this function to hide away instanceId -> entityId migration that happened in Unity 6.4

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

[u-pr-agent]

PR Code Suggestions ✨

No code suggestions found for the PR.

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2257      +/-   ##
===========================================
+ Coverage    76.70%   76.72%   +0.01%     
===========================================
  Files          465      465              
  Lines        87919    87945      +26     
===========================================
+ Hits         67442    67473      +31     
+ Misses       20477    20472       -5     

Flag	Coverage Δ
inputsystem_MacOS_2022.3	5.37% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_2022.3_project	74.60% <100.00%> (+0.02%)	⬆️
inputsystem_MacOS_6000.0	5.18% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.0_project	76.52% <100.00%> (+0.01%)	⬆️
inputsystem_MacOS_6000.2	5.18% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.2_project	76.52% <100.00%> (+0.01%)	⬆️
inputsystem_MacOS_6000.3	5.19% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.3_project	76.52% <100.00%> (+0.01%)	⬆️
inputsystem_MacOS_6000.4	5.19% <0.00%> (-0.01%)	⬇️
inputsystem_MacOS_6000.4_project	76.52% <100.00%> (+0.01%)	⬆️
inputsystem_Ubuntu_2021.3	5.91% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_2022.3	5.38% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_2022.3_project	74.41% <100.00%> (+0.02%)	⬆️
inputsystem_Ubuntu_6000.0	5.19% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.0_project	76.33% <100.00%> (+0.01%)	⬆️
inputsystem_Ubuntu_6000.2	5.19% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.2_project	76.33% <100.00%> (+0.01%)	⬆️
inputsystem_Ubuntu_6000.3	5.19% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.3_project	76.33% <100.00%> (+0.01%)	⬆️
inputsystem_Ubuntu_6000.4	5.19% <0.00%> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.4_project	76.33% <100.00%> (+0.01%)	⬆️
inputsystem_Windows_2021.3	5.91% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_2022.3	5.37% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_2022.3_project	74.74% <100.00%> (+0.02%)	⬆️
inputsystem_Windows_6000.0	5.18% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.0_project	76.66% <100.00%> (+0.01%)	⬆️
inputsystem_Windows_6000.2	5.18% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.2_project	76.66% <100.00%> (+0.01%)	⬆️
inputsystem_Windows_6000.3	5.19% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.3_project	76.66% <100.00%> (+0.02%)	⬆️
inputsystem_Windows_6000.4	5.19% <0.00%> (-0.01%)	⬇️
inputsystem_Windows_6000.4_project	76.66% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
Assets/Tests/InputSystem/CorePerformanceTests.cs	0.00% <ø> (ø)
...em/InputSystem/Devices/Precompiled/FastKeyboard.cs	100.00% <ø> (ø)
...ystem/InputSystem/Devices/Precompiled/FastMouse.cs	100.00% <ø> (ø)
...InputSystem/Devices/Precompiled/FastTouchscreen.cs	100.00% <ø> (ø)
...stem/Editor/AssetEditor/InputActionEditorWindow.cs	0.00% <ø> (ø)
...tem/InputSystem/Editor/InputLayoutCodeGenerator.cs	97.16% <100.00%> (+0.01%)	⬆️
...Editor/UITKAssetEditor/InputActionsEditorWindow.cs	49.31% <ø> (ø)
...s/com.unity.inputsystem/InputSystem/InputSystem.cs	83.05% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ekcoh]

Outdated Comment
The comment on line 3698 refers to a migration in "Unity 6.4", but the associated preprocessor directive was updated to UNITY_6000_3_OR_NEWER. The comment should be updated to reflect this change for consistency.

This was addressed in a8357e7

[K-Tone]

thanks for fixing up my changes as well, awesome!

[ekcoh]

Found an additional warning on 2021.3 addressed in 78027e2. I verified it myself so I do not consider re-review required unless there are objections.

[ekcoh]

Will merge this as soon as CI rerun is completed