-
Notifications
You must be signed in to change notification settings - Fork 329
CHANGE: update supported editor to 2022.3 for the package #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this.
I think we still need to upgrade the minor package version. We did the same last time we bumped the minimum supported version, see #2116
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2271 +/- ##
===========================================
+ Coverage 76.70% 76.80% +0.10%
===========================================
Files 465 476 +11
Lines 87919 88644 +725
===========================================
+ Hits 67442 68087 +645
- Misses 20477 20557 +80 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 🚀 New features to boost your workflow:
|
docs say https://internaldocs.unity.com/package_development/package-manager/semantic-version/#other-changes-allowed-in-new-major-or-minor-releases it can be done via patch, but I can also increase in this PR if you want? |
never mind, CI is already yelling at me, will bump to next minor |
|
The one red job is wrong reporting logic. I canceled that one due to being stuck, rerun to green and the parent job https://unity-ci.cds.internal.unity3d.com/job/58462775/dependency-graph is also green. |
Description
Now that 2021.3 is no longer supported we can increase the minimum supported version to 2022.3 and remove it from our CI jobs.
Testing status & QA
-CI is green
Overall Product Risks
None
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: