Skip to content

Conversation

@stefanunity
Copy link
Collaborator

Description

Now that 2021.3 is no longer supported we can increase the minimum supported version to 2022.3 and remove it from our CI jobs.

Testing status & QA

-CI is green

Overall Product Risks

None

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Oct 29, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR consists of a single-line change in a configuration file to update the minimum supported Unity version.
🏅 Score: 100

The change is correct, aligns perfectly with the PR's description, and has no apparent issues.
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

Copy link
Collaborator

@jfreire-unity jfreire-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

I think we still need to upgrade the minor package version. We did the same last time we bumped the minimum supported version, see #2116

@codecov-github-com
Copy link

codecov-github-com bot commented Oct 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2271      +/-   ##
===========================================
+ Coverage    76.70%   76.80%   +0.10%     
===========================================
  Files          465      476      +11     
  Lines        87919    88644     +725     
===========================================
+ Hits         67442    68087     +645     
- Misses       20477    20557      +80     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.39% <ø> (+0.02%) ⬆️
inputsystem_MacOS_2022.3_project 74.74% <ø> (+0.15%) ⬆️
inputsystem_MacOS_6000.0 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 76.60% <ø> (+0.09%) ⬆️
inputsystem_MacOS_6000.2 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.2_project 76.60% <ø> (+0.09%) ⬆️
inputsystem_MacOS_6000.3 5.18% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 76.59% <ø> (+0.09%) ⬆️
inputsystem_MacOS_6000.4 5.19% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.4_project 76.61% <ø> (+0.10%) ⬆️
inputsystem_MacOS_6000.5 5.19% <ø> (?)
inputsystem_MacOS_6000.5_project 76.61% <ø> (?)
inputsystem_Ubuntu_2022.3 5.40% <ø> (+0.02%) ⬆️
inputsystem_Ubuntu_2022.3_project 74.54% <ø> (+0.14%) ⬆️
inputsystem_Ubuntu_6000.0 5.19% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 76.40% <ø> (+0.08%) ⬆️
inputsystem_Ubuntu_6000.2 5.19% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.2_project 76.40% <ø> (+0.08%) ⬆️
inputsystem_Ubuntu_6000.3 5.19% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 76.40% <ø> (+0.08%) ⬆️
inputsystem_Ubuntu_6000.4 5.19% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.4_project 76.41% <ø> (+0.08%) ⬆️
inputsystem_Ubuntu_6000.5 5.19% <ø> (?)
inputsystem_Ubuntu_6000.5_project 76.41% <ø> (?)
inputsystem_Windows_2022.3 5.39% <ø> (+0.02%) ⬆️
inputsystem_Windows_2022.3_project 74.87% <ø> (+0.14%) ⬆️
inputsystem_Windows_6000.0 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 76.72% <ø> (+0.07%) ⬆️
inputsystem_Windows_6000.2 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.2_project 76.72% <ø> (+0.07%) ⬆️
inputsystem_Windows_6000.3 5.18% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 76.72% <ø> (+0.08%) ⬆️
inputsystem_Windows_6000.4 5.19% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.4_project 76.73% <ø> (+0.08%) ⬆️
inputsystem_Windows_6000.5 5.19% <ø> (?)
inputsystem_Windows_6000.5_project 76.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Assets/Samples/InGameHints/InGameHintsActions.cs 17.69% <ø> (ø)
...sts/InputSystem/InputActionCodeGeneratorActions.cs 59.49% <ø> (ø)
...em/InputSystem/Devices/Precompiled/FastKeyboard.cs 100.00% <ø> (ø)
...ystem/InputSystem/Devices/Precompiled/FastMouse.cs 100.00% <ø> (ø)
...InputSystem/Devices/Precompiled/FastTouchscreen.cs 100.00% <ø> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefanunity
Copy link
Collaborator Author

Thanks for doing this.

I think we still need to upgrade the minor package version. We did the same last time we bumped the minimum supported version, see #2116

docs say https://internaldocs.unity.com/package_development/package-manager/semantic-version/#other-changes-allowed-in-new-major-or-minor-releases it can be done via patch, but I can also increase in this PR if you want?

@stefanunity
Copy link
Collaborator Author

Thanks for doing this.
I think we still need to upgrade the minor package version. We did the same last time we bumped the minimum supported version, see #2116

docs say https://internaldocs.unity.com/package_development/package-manager/semantic-version/#other-changes-allowed-in-new-major-or-minor-releases it can be done via patch, but I can also increase in this PR if you want?

never mind, CI is already yelling at me, will bump to next minor

@jfreire-unity jfreire-unity self-requested a review October 30, 2025 10:21
@stefanunity
Copy link
Collaborator Author

The one red job is wrong reporting logic. I canceled that one due to being stuck, rerun to green and the parent job https://unity-ci.cds.internal.unity3d.com/job/58462775/dependency-graph is also green.

@stefanunity stefanunity merged commit 85b57c7 into develop Oct 30, 2025
126 of 127 checks passed
@stefanunity stefanunity deleted the remove-21.3-from-ci branch October 30, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants