-
Notifications
You must be signed in to change notification settings - Fork 329
FIX: Summary update fixing a bug for TapInteraction #2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
FIX: Summary update fixing a bug for TapInteraction #2308
Conversation
The interaction requires the control to be released within the timeout (the code uses <= durationOrDefault and cancels on timer expiry), so the comment should say "at most" / "within".
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
PR Code Suggestions ✨No code suggestions found for the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2308 +/- ##
========================================
Coverage 77.95% 77.95%
========================================
Files 476 476
Lines 97443 97443
========================================
Hits 75961 75961
Misses 21482 21482 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Description
The interaction requires the control to be released within the timeout (the code uses <= durationOrDefault and cancels on timer expiry), so the comment should say "at most" / "within".
Testing status & QA
N/A
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Review carefully.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.