Skip to content

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Jan 8, 2026

Description

Icon fix for action maps buttons in background and resolution #2314

image (4)

JIRA: https://jira.unity3d.com/browse/UUM-131889

Testing status & QA

Screen.Recording.2026-01-08.at.12.45.15.mov

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: low
  • Halo Effect: low

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Jan 8, 2026
@josepmariapujol-unity josepmariapujol-unity changed the title Fixing icon width/height FIX: Icon fix for action maps background and resolution Jan 8, 2026
@josepmariapujol-unity josepmariapujol-unity marked this pull request as ready for review January 8, 2026 11:49
@josepmariapujol-unity josepmariapujol-unity changed the title FIX: Icon fix for action maps background and resolution FIX: Icon fix for action maps buttons in background and resolution Jan 8, 2026
@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 8, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

Small UI markup/style adjustments with limited surface area, but should be validated across themes/scales and different Editor skins.
🏅 Score: 85

Changes look targeted and improve consistency, but a few UI/UX details (explicit sizing, accessibility, theme interactions) should be verified before merge.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

UI Regression

Removing the inline transparent background-color on the add buttons may reintroduce unwanted default button backgrounds depending on theme/skin and Unity version; confirm the styling is now fully controlled via USS and remains visually correct.

        <ui:Button display-tooltip-when-elided="true" name="add-new-action-map-button" style="align-items: auto;" />
    </ui:VisualElement>
    <ui:VisualElement name="body">
        <ui:ListView focusable="true" name="action-maps-list-view" />
    </ui:VisualElement>
    <ui:VisualElement name="rclick-area-to-add-new-action-map" style="flex-direction: column; flex-grow: 1;" />
</ui:VisualElement>
<ui:TwoPaneSplitView name="actions-and-properties-split-view" fixed-pane-index="1" fixed-pane-initial-dimension="320" view-data-key="actions-editor-splitter-2" style="height: auto; min-width: 450px;">
    <ui:VisualElement name="actions-container" class="body-panel-container">
        <ui:VisualElement name="header" class="body-panel-header" style="justify-content: space-between;">
            <ui:Label text="Actions" display-tooltip-when-elided="true" name="actions-label" />
            <ui:Button display-tooltip-when-elided="true" name="add-new-action-button" style="align-items: auto;" />
        </ui:VisualElement>
Icon Sizing

Hard-coding width/height to 16px for toolbar icon buttons could look off at different Editor UI scales (e.g., 125–200%) or on HiDPI; verify the icons remain crisp and aligned and consider whether using min-width/min-height or letting the container drive sizing is preferable.

.add-binging-button-dark-theme {
    width: 16px;
    height: 16px;
    background-image: resource('d_Toolbar Plus More.png');
    background-color: transparent;
    -unity-background-scale-mode: scale-to-fit;
}

.add-binging-button {
    width: 16px;
    height: 16px;
    background-image: resource('Toolbar Plus More.png');
    background-color: transparent;
    -unity-background-scale-mode: scale-to-fit;
}

.add-button-dark-theme {
    width: 16px;
    height: 16px;
    background-image: resource('d_Toolbar Plus.png');
    background-color: transparent;
    -unity-background-scale-mode: scale-to-fit;
}

.add-button {
    width: 16px;
    height: 16px;
    background-image: resource('Toolbar Plus.png');
    background-color: transparent;
    -unity-background-scale-mode: scale-to-fit;
}
Click Target

Setting background-color: transparent is fine visually, but ensure the button still has an adequate hit area and visible hover/active feedback (especially in dark theme) so the control remains discoverable and accessible.

.add-binging-button-dark-theme {
    width: 16px;
    height: 16px;
    background-image: resource('d_Toolbar Plus More.png');
    background-color: transparent;
    -unity-background-scale-mode: scale-to-fit;
}

.add-binging-button {
    width: 16px;
    height: 16px;
    background-image: resource('Toolbar Plus More.png');
    background-color: transparent;
    -unity-background-scale-mode: scale-to-fit;
}

.add-button-dark-theme {
    width: 16px;
    height: 16px;
    background-image: resource('d_Toolbar Plus.png');
    background-color: transparent;
    -unity-background-scale-mode: scale-to-fit;
}

.add-button {
    width: 16px;
    height: 16px;
    background-image: resource('Toolbar Plus.png');
    background-color: transparent;
    -unity-background-scale-mode: scale-to-fit;
}
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 8, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov-github-com
Copy link

codecov-github-com bot commented Jan 8, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2314   +/-   ##
========================================
  Coverage    77.95%   77.95%           
========================================
  Files          476      476           
  Lines        97443    97443           
========================================
  Hits         75961    75961           
  Misses       21482    21482           
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <ø> (ø)
inputsystem_MacOS_2022.3_project 75.47% <ø> (ø)
inputsystem_MacOS_6000.0 5.32% <ø> (ø)
inputsystem_MacOS_6000.0_project 77.36% <ø> (ø)
inputsystem_MacOS_6000.2 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.2_project 77.36% <ø> (ø)
inputsystem_MacOS_6000.3 5.32% <ø> (ø)
inputsystem_MacOS_6000.3_project 77.36% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4 5.32% <ø> (ø)
inputsystem_MacOS_6000.4_project 77.37% <ø> (+<0.01%) ⬆️
inputsystem_MacOS_6000.5 5.32% <ø> (ø)
inputsystem_MacOS_6000.5_project 77.36% <ø> (ø)
inputsystem_Ubuntu_2022.3 5.54% <ø> (ø)
inputsystem_Ubuntu_2022.3_project 75.26% <ø> (ø)
inputsystem_Ubuntu_6000.0 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.0_project 77.16% <ø> (ø)
inputsystem_Ubuntu_6000.2 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.2_project 77.16% <ø> (ø)
inputsystem_Ubuntu_6000.3 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.3_project 77.16% <ø> (ø)
inputsystem_Ubuntu_6000.4 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.4_project 77.17% <ø> (ø)
inputsystem_Ubuntu_6000.5 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.5_project 77.17% <ø> (ø)
inputsystem_Windows_2022.3 5.54% <ø> (ø)
inputsystem_Windows_2022.3_project 75.60% <ø> (ø)
inputsystem_Windows_6000.0 5.32% <ø> (ø)
inputsystem_Windows_6000.0_project 77.49% <ø> (ø)
inputsystem_Windows_6000.2 5.32% <ø> (ø)
inputsystem_Windows_6000.2_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3 5.32% <ø> (ø)
inputsystem_Windows_6000.3_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.4 5.32% <ø> (ø)
inputsystem_Windows_6000.4_project 77.49% <ø> (ø)
inputsystem_Windows_6000.5 5.32% <ø> (ø)
inputsystem_Windows_6000.5_project 77.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pauliusd01 Pauliusd01 self-requested a review January 8, 2026 12:47
Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, checked 100%, 125% and 200% windows scaling with dark/light modes.

@josepmariapujol-unity josepmariapujol-unity merged commit ffb1879 into develop Jan 8, 2026
130 of 131 checks passed
@josepmariapujol-unity josepmariapujol-unity deleted the input/icons-resolution-bug branch January 8, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants