Skip to content

CHANGE: Removing TODOs and moving them to jira tasks #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
josepmariapujol-unity wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

CHANGE: Removing TODOs and moving them to jira tasks #2316

josepmariapujol-unity wants to merge 2 commits into from

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Jan 9, 2026 •
edited
Loading

Description

Removing TODOs and moving them to jira tasks:

  1. ISX-2443 - Removing TODO: InputSystem.cs
  2. ISX-2442 - Removing TODO: InputSettings.cs
  3. ISX-2441 - Removing TODO: InputManager.cs
  4. ISX-2440 - Removing TODO: InputStateHistory.cs
  5. ISX-2439 - Removing TODO: InputStateBlock.cs
  6. ISX-2438 - Removing TODO: SteamIGAConverter.cs
  7. ISX-2437 - Removing TODO: Touchscreen.cs
  8. ISX-2436 - Removing TODO: Pointer.cs
  9. ISX-2435 - Removing TODO: InputControlLayout.cs
  10. ISX-2434 - Removing TODO: InputControl.cs
  11. ISX-2433 - Removing TODO: InputBindingComposite.cs
  12. ISX-2432 - Removing TODO: InputActionTrace.cs

Testing status & QA

n/a

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: low
  • Halo Effect: low

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Jan 9, 2026
@josepmariapujol-unity josepmariapujol-unity marked this pull request as ready for review January 9, 2026 14:16
@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 9, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The diff only removes comment TODO/REVIEW/FIXME blocks without any functional code changes.
🏅 Score: 97

The change is low-risk and improves code cleanliness, but it removes in-code documentation that may have been useful without leaving pointers in the source.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Traceability

Consider leaving a brief reference (e.g., a single comment) to the tracking tickets for removed design/bug notes so future maintainers can discover the rationale and follow-up work from the code location.

 
using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Runtime.CompilerServices;
using UnityEngine.InputSystem.Haptics;
using Unity.Collections.LowLevel.Unsafe;
using UnityEngine.InputSystem.Controls;
using UnityEngine.InputSystem.Layouts;
using UnityEngine.InputSystem.LowLevel;
using UnityEngine.InputSystem.DualShock;
using UnityEngine.InputSystem.EnhancedTouch;
using UnityEngine.InputSystem.HID;
using UnityEngine.InputSystem.Users;
using UnityEngine.InputSystem.XInput;
using UnityEngine.InputSystem.Utilities;
using Unity.Profiling;

#if UNITY_EDITOR
using UnityEditor;
using UnityEngine.InputSystem.Editor;
using UnityEditor.Networking.PlayerConnection;
#else
using System.Linq;
using UnityEngine.Networking.PlayerConnection;
#endif

#if UNITY_EDITOR
using CustomBindingPathValidator = System.Func<string, System.Action>;
#endif

namespace UnityEngine.InputSystem
{
    /// <summary>
    /// This is the central hub for the input system.
Lost Context

Removing REVIEW notes may reduce discoverability of known architectural concerns; validate that the corresponding Jira tasks capture enough context and that team conventions don’t require keeping certain review notes inline.

 
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Text;
using Unity.Collections;
using UnityEngine.InputSystem.Composites;
using UnityEngine.InputSystem.Controls;
using Unity.Collections.LowLevel.Unsafe;
using UnityEngine.InputSystem.LowLevel;
using UnityEngine.InputSystem.Processors;
using UnityEngine.InputSystem.Interactions;
using UnityEngine.InputSystem.Utilities;
using UnityEngine.InputSystem.Layouts;
using Unity.Profiling;
using UnityEngineInternal.Input;
#if UNITY_6000_5_OR_NEWER
using UnityEngine.Assemblies;
#endif

#if UNITY_EDITOR
using UnityEngine.InputSystem.Editor;
#endif

#if UNITY_EDITOR
using CustomBindingPathValidator = System.Func<string, System.Action>;
#endif

#pragma warning disable CS0649
namespace UnityEngine.InputSystem
{
    using DeviceChangeListener = Action<InputDevice, InputDeviceChange>;
Documentation Gap

Several removed notes relate to alignment and layout verification; ensure these concerns are now documented/owned elsewhere (Jira/design docs) to avoid regressions or repeated rediscovery during future refactors.

 
using System;
using System.Runtime.CompilerServices;
using Unity.Collections.LowLevel.Unsafe;
using UnityEngine.InputSystem.Utilities;

namespace UnityEngine.InputSystem.LowLevel
{
    /// <summary>
    /// Information about a memory region storing input state.
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 9, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov-github-com
Copy link

codecov-github-com bot commented Jan 9, 2026 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2316   +/-   ##
========================================
  Coverage    77.95%   77.95%           
========================================
  Files          476      476           
  Lines        97443    97445    +2     
========================================
+ Hits         75961    75963    +2     
  Misses       21482    21482
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <ø> (ø)
inputsystem_MacOS_2022.3_project 75.47% <ø> (ø)
inputsystem_MacOS_6000.0 5.32% <ø> (ø)
inputsystem_MacOS_6000.0_project 77.36% <ø> (ø)
inputsystem_MacOS_6000.2 5.32% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.2_project 77.36% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3 5.32% <ø> (ø)
inputsystem_MacOS_6000.3_project 77.36% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4 5.32% <ø> (ø)
inputsystem_MacOS_6000.4_project 77.36% <ø> (ø)
inputsystem_MacOS_6000.5 5.32% <ø> (ø)
inputsystem_MacOS_6000.5_project 77.36% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3 5.54% <ø> (ø)
inputsystem_Ubuntu_2022.3_project 75.26% <ø> (ø)
inputsystem_Ubuntu_6000.0 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.0_project 77.16% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.2 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.2_project 77.16% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.3_project 77.17% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.4 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.4_project 77.17% <ø> (ø)
inputsystem_Ubuntu_6000.5 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.5_project 77.17% <ø> (ø)
inputsystem_Windows_2022.3 5.54% <ø> (ø)
inputsystem_Windows_2022.3_project 75.60% <ø> (ø)
inputsystem_Windows_6000.0 5.32% <ø> (ø)
inputsystem_Windows_6000.0_project 77.49% <ø> (ø)
inputsystem_Windows_6000.2 5.32% <ø> (ø)
inputsystem_Windows_6000.2_project 77.49% <ø> (ø)
inputsystem_Windows_6000.3 5.32% <ø> (ø)
inputsystem_Windows_6000.3_project 77.49% <ø> (ø)
inputsystem_Windows_6000.4 5.32% <ø> (ø)
inputsystem_Windows_6000.4_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.5 5.32% <ø> (ø)
inputsystem_Windows_6000.5_project 77.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nputsystem/InputSystem/Actions/InputActionTrace.cs 84.45% <ø> (ø)
...ystem/InputSystem/Actions/InputBindingComposite.cs 50.00% <ø> (ø)
...y.inputsystem/InputSystem/Controls/InputControl.cs 83.40% <ø> (ø)
...tsystem/InputSystem/Controls/InputControlLayout.cs 88.32% <ø> (ø)
...m.unity.inputsystem/InputSystem/Devices/Pointer.cs 93.02% <ø> (ø)
...ity.inputsystem/InputSystem/Devices/Touchscreen.cs 91.23% <ø> (ø)
.../com.unity.inputsystem/InputSystem/InputManager.cs 91.77% <ø> (ø)
...com.unity.inputsystem/InputSystem/InputSettings.cs 82.14% <ø> (ø)
...s/com.unity.inputsystem/InputSystem/InputSystem.cs 84.37% <ø> (ø)
...tem/InputSystem/Plugins/Steam/SteamIGAConverter.cs 87.12% <ø> (ø)
... and 2 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekcoh ekcoh Awaiting requested review from ekcoh

At least 1 approving review is required to merge this pull request.

Assignees

@josepmariapujol-unity josepmariapujol-unity

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josepmariapujol-unity