Skip to content

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Jan 19, 2026

Description

This PR fixes the Auto-Save button misalignment reported by the editor-consistency-team.

Before:
Screenshot 2026-01-19 at 13 55 50

After:
Screenshot 2026-01-19 at 13 55 59

JIRA: ISX-2340

Testing status & QA

No testing, simply compiled the file and running CI.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 1
  • Halo Effect: 1

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@u-pr
Copy link
Contributor

u-pr bot commented Jan 19, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

Small, UI-only UXML adjustments with limited behavioral impact and straightforward validation in the editor.
🏅 Score: 90

Change is minimal and likely safe, but a couple of UI robustness concerns (hard-coded sizing and duplicate element names) should be validated.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

UI Robustness

The auto-save-toolbar-toggle uses a hard-coded width which may not scale well with different editor font sizes, DPI scaling, or localization; consider relying on USS/layout or min-width instead of a fixed pixel width.

<uie:ToolbarToggle focusable="false" label="Auto-Save" name="auto-save-toolbar-toggle" style="width: 76px;"/>
Duplicate Name

Two different labels share the same name (no-parameters-added-label), which can make Q()/UXML queries ambiguous and lead to the wrong element being found or modified at runtime.

    <ui:Label text="No interactions have been added." name="no-parameters-added-label" display-tooltip-when-elided="true" class="name-and-parameter-empty-label" style="display: flex;"/>
</ui:Foldout>
<ui:Foldout text="Processors" name="processors-foldout" class="properties-foldout name-and-parameters-list-view">
    <ui:Label text="No processors have been added." name="no-parameters-added-label" display-tooltip-when-elided="true" class="name-and-parameter-empty-label"/>
</ui:Foldout>
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr
Copy link
Contributor

u-pr bot commented Jan 19, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Jan 19, 2026
Co-authored-by: Anthony Yakovlev <anthony.yakovlev@gmail.com>
Copy link
Collaborator

@K-Tone K-Tone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@josepmariapujol-unity josepmariapujol-unity merged commit 0f225ca into develop Jan 19, 2026
35 of 105 checks passed
@josepmariapujol-unity josepmariapujol-unity deleted the input/ui-input-action-map-window branch January 19, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants