code review fixes

-show popup if trying to install to 3dsmax 2016 or earlier
-remove log when trying to find 3dsmax in default location
-reword logging of exit code
-change warning to error in max plugin

Author: vkovec

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -135,8 +135,12 @@ public override void OnInspectorGUI() {
                     ExportSettings.DCCType foundDCC = ExportSettings.DCCType.Maya;
                     var foundDCCPath = TryFindDCC (dccPath, ext, ExportSettings.DCCType.Maya);
                     if (foundDCCPath == null && Application.platform == RuntimePlatform.WindowsEditor) {
-                        if (!ExportSettings.IsEarlierThanMax2017 (dccPath)) {
-                            Debug.LogWarning ("Earlier than 3ds Max 2017 is not supported");
+                        if (ExportSettings.IsEarlierThanMax2017 (dccPath)) {
+                            Debug.LogError ("Earlier than 3ds Max 2017 is not supported");
+                            UnityEditor.EditorUtility.DisplayDialog (
+                                "Error adding 3D Application",
+                                "Unity Integration only supports 3ds Max 2017 or later",
+                                "Ok");
                         } else {
                             foundDCCPath = TryFindDCC (dccPath, ext, ExportSettings.DCCType.Max);
                             foundDCC = ExportSettings.DCCType.Max;
@@ -348,8 +352,7 @@ private static void FindDCCInstalls() {
 
                 if (product.StartsWith ("3ds max", StringComparison.InvariantCultureIgnoreCase)) {
                     var exePath = string.Format ("{0}/{1}", productDir.FullName.Replace ("\\", "/"), "3dsmax.exe");
-                    if (!IsEarlierThanMax2017 (exePath)) {
-                        Debug.LogWarning ("Earlier than 3ds Max 2017 is not supported");
+                    if (IsEarlierThanMax2017 (exePath)) {
                         continue;
                     }
                     string version = product.Substring ("3ds max ".Length);

Assets/FbxExporters/Editor/InstallIntegration.cs

@@ -534,7 +534,7 @@ public static int InstallMaxPlugin(string maxExe){
 
                 // TODO (UNI-29910): figure out what exactly causes this exit code + how to resolve
                 if(ExitCode == -1073740791){
-                    Debug.LogWarning(string.Format("3ds Max exited with code: {0}, ignoring as this does not affect plugin installation", ExitCode));
+                    Debug.Log(string.Format("Detected 3ds max exitcode {0} -- safe to ignore", ExitCode));
                     ExitCode = 0;
                 }
 

Assets/Integrations/Autodesk/max/scripts/UnityFbxForMaxPlugin.ms

@@ -213,5 +213,5 @@ else if (maxVersion())[1] == 19000 then (
 	)
 )
 else(
-    print "Warning: Unity Integration not supported for 3ds Max versions earlier than 3ds Max 2017"
+    print "Error: Unity Integration only supports 3ds Max 2017 or later"
 )