Merge pull request #255 from Unity-Technologies/UNI-33630-update-UX-for-missing-script-fix

UNI-33630 update UX for missing script fix

Author: vkovec

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -180,27 +180,40 @@ public override void OnInspectorGUI() {
             }
             EditorGUI.EndDisabledGroup ();
 
-            if (!HideRepairMissingScripts ()) {
-                EditorGUILayout.Space ();
-
-                EditorGUI.indentLevel--;
-                EditorGUILayout.LabelField ("Repair Missing Scripts", EditorStyles.boldLabel);
-                EditorGUI.indentLevel++;
+            EditorGUILayout.Space ();
 
-                EditorGUILayout.Space ();
+            EditorGUI.indentLevel--;
+            EditorGUILayout.LabelField ("Run Component Updater", EditorStyles.boldLabel);
+            EditorGUI.indentLevel++;
 
-                var repairMissingScripts = new GUIContent (
-                                           "Repair Missing Scripts",
-                                           "Repair missing FbxPrefab scripts in text assets");
-                if (GUILayout.Button (repairMissingScripts)) {
-                    bool result = FbxExporters.Editor.RepairMissingScripts.ReplaceGUIDInTextAssets ();
+            EditorGUILayout.Space ();
+
+            var repairMissingScripts = new GUIContent (
+                                       "Run Component Updater",
+                                        "If the forum package 1.1.0b1 was previously installed, then links to the FbxPrefab component " +
+                                        "in assets created with the FBX exporter will need updating.\n" +
+                                        "Run this button to update all FbxPrefab references in text serialized prefabs and scene files.");
+
+            if (GUILayout.Button (repairMissingScripts)) {
+                var componentUpdater = new FbxExporters.Editor.RepairMissingScripts ();
+                var filesToRepairCount = componentUpdater.GetAssetsToRepairCount ();
+                var dialogTitle = "FBX Exporter Component Updater";
+                if (filesToRepairCount > 0) {
+                    bool result = UnityEditor.EditorUtility.DisplayDialog (dialogTitle,
+                        string.Format("Found {0} prefab and/or scene file(s) with components requiring update.\n\n" +
+                        "If you choose 'Go Ahead', the FbxPrefab components in these assets " +
+                        "will be automatically updated to work with the latest FBX exporter.\n" +
+                            "You should make a backup before proceeding.", filesToRepairCount),
+                        "I Made a Backup. Go Ahead!", "No Thanks");
                     if (result) {
-                        UnityEditor.EditorUtility.DisplayDialog ("Finished Repairing Scripts",
-                            "Repaired missing scripts in text serialized assets", "Ok");
+                        componentUpdater.ReplaceGUIDInTextAssets ();
                     } else {
-                        UnityEditor.EditorUtility.DisplayDialog ("Finished Repairing Scripts",
-                            "Couldn't find any assets needing repair", "Ok");
+                        var assetsToRepair = componentUpdater.GetAssetsToRepair ();
+                        Debug.LogFormat ("Failed to update the FbxPrefab components in the following files:\n{0}", string.Join ("\n", assetsToRepair));
                     }
+                } else {
+                    UnityEditor.EditorUtility.DisplayDialog (dialogTitle,
+                        "Couldn't find any text assets that require updating", "Ok");
                 }
             }
 
@@ -214,11 +227,6 @@ public override void OnInspectorGUI() {
             }
         }
 
-        private static bool HideRepairMissingScripts(){
-            var docPath = Application.dataPath + "/FbxExporters/FBX_Exporter_User_Guide_v1.1.0b1.pdf";
-            return File.Exists(docPath)? false : true;
-        }
-
         private static string TryFindDCC(string dccPath, string ext, ExportSettings.DCCType dccType){
             string dccName = "";
             switch (dccType) {

Assets/FbxExporters/Editor/FbxExporterRepairMissingScripts.cs

@@ -15,7 +15,6 @@ public class RepairMissingScripts
 
         private const string m_idFormat = "{{fileID: {0}, guid: {1}, type:";
 
-
         private static string m_forumPackageSearchID;
 
         private static string ForumPackageSearchID {
@@ -38,24 +37,78 @@ private static string CurrentPackageSearchID {
             }
         }
 
-        public static bool ReplaceGUIDInTextAssets ()
+        private string[] m_assetsToRepair;
+        private string[] AssetsToRepair{
+            get{
+                if (m_assetsToRepair == null) {
+                    m_assetsToRepair = FindAssetsToRepair ();
+                }
+                return m_assetsToRepair;
+            }
+        }
+
+        public int GetAssetsToRepairCount(){
+            return AssetsToRepair.Length;
+        }
+
+        public string[] GetAssetsToRepair(){
+            return AssetsToRepair;
+        }
+
+        public static string[] FindAssetsToRepair()
         {
             // search project for assets containing old GUID
 
             // ignore if forced binary
             if (UnityEditor.EditorSettings.serializationMode == SerializationMode.ForceBinary) {
-                return false;
+                return new string[]{};
             }
 
             // check all scenes and prefabs
             string[] searchFilePatterns = new string[]{ "*.prefab", "*.unity" };
 
-            bool replacedGUID = false;
+            List<string> assetsToRepair = new List<string> ();
             foreach (string searchPattern in searchFilePatterns) {
                 foreach (string file in Directory.GetFiles(Application.dataPath, searchPattern, SearchOption.AllDirectories)) {
-                    replacedGUID |= ReplaceGUIDInFile (file);
+                    if (AssetNeedsRepair (file)) {
+                        assetsToRepair.Add (file);
+                    }
                 }
             }
+            return assetsToRepair.ToArray ();
+        }
+
+        private static bool AssetNeedsRepair(string filePath)
+        {
+            try{
+                using(var sr = new StreamReader (filePath)){
+                    if(sr.Peek() > -1){
+                        var firstLine = sr.ReadLine();
+                        if(!firstLine.StartsWith("%YAML")){
+                            sr.Close();
+                            return false;
+                        }
+                    }
+
+                    var contents = sr.ReadToEnd();
+                    if(contents.Contains(ForumPackageSearchID)){
+                        sr.Close();
+                        return true;
+                    }
+                }
+            }
+            catch(IOException e){
+                Debug.LogError (string.Format ("Failed to check file for component update: {0} (error={1})", filePath, e));
+            }
+            return false;
+        }
+
+        public bool ReplaceGUIDInTextAssets ()
+        {
+            bool replacedGUID = false;
+            foreach (string file in AssetsToRepair) {
+                replacedGUID |= ReplaceGUIDInFile (file);
+            }
             if (replacedGUID) {
                 AssetDatabase.Refresh ();
             }
@@ -105,6 +158,8 @@ private static bool ReplaceGUIDInFile (string path)
                 if (modified) {
                     File.Delete (path);
                     File.Move (tmpFile, path);
+
+                    Debug.LogFormat("Updated FbxPrefab components in file {0}", path);
                     return true;
                 } else {
                     File.Delete (tmpFile);