Ut 3769 change Recorder to optional dependency + min Unity version 2019.4 (#548)

* make the recorder an optional dependency

* Update minimum supported Unity version to 2019.4.

* update recorder doc

* code review fix - update doc link

Author: vkovec

.yamato/promotion.yml

@@ -6,7 +6,7 @@
 # tests.
 #
 test_editors:
-  - version: 2019.3
+  - version: 2019.4
 test_platforms:
   - name: win
     type: Unity::VM

.yamato/upm-ci.yml

@@ -1,11 +1,7 @@
 test_trigger_editors:
-  - version: 2018.4
   - version: 2019.4
+  - version: 2020.1
 publish_trigger_editors:
-  - version: 2018.4
-  - version: 2019.1
-  - version: 2019.2
-  - version: 2019.3
   - version: 2019.4
   - version: 2020.1
 platforms:

CHANGELOG.md

@@ -17,6 +17,8 @@
     - There may be discrepancies in the Aim constraint and Parent constraint export result compared to before, however these should still import correctly into Autodesk® Maya® and other DCCs.
 - Export animation curve tangents instead of baking animation.
     - For more details see https://docs.unity3d.com/Packages/[email protected]/manual/exporting.html#animation
+- Change dependency on Unity Recorder to an optional one so it is no longer immediately installed when installing the FBX exporter package.
+- Update minimum supported Unity version to 2019.4.
 
 ### Fixed
 - Fix Export Model and Convert to Prefab Variant setting presets not serializing settings properly.

com.unity.formats.fbx/Documentation~/index.md

@@ -14,7 +14,7 @@ The FBX Exporter package includes the following features:
 
 The FBX Exporter package is compatible with the following versions of the Unity Editor:
 
-* 2018.3 and later
+* 2019.4 and later
 
 The Unity Integration for Autodesk® Maya® and Autodesk® Maya LT™ feature supports the following versions:
 

com.unity.formats.fbx/Documentation~/recorder.md

@@ -1,9 +1,10 @@
 # FBX Recorder
 
-With the FBX Exporter and the [Unity Recorder](https://docs.unity3d.com/Packages/com.unity.recorder@2.1/index.html), it is possible to export animations (including [Cinemachine](https://docs.unity3d.com/Packages/[email protected]/manual/index.html) camera animations) directly to FBX in a few easy steps:
+With the FBX Exporter and the [Unity Recorder](https://docs.unity3d.com/Packages/com.unity.recorder@2.2/index.html), it is possible to export animations (including [Cinemachine](https://docs.unity3d.com/Packages/[email protected]/manual/index.html) camera animations) directly to FBX in a few easy steps:
 
-1. Open the Recorder window by selecting (Window > General > Recorder > Recorder Window)
-2. In the Recorder window add a new FBX recorder
+1. Install the Unity Recorder package from the [Package Manager](https://docs.unity3d.com/Manual/upm-ui-install.html) if it is not already in the project
+2. Open the Recorder window by selecting (Window > General > Recorder > Recorder Window)
+3. In the Recorder window add a new FBX recorder
 
 ![](images/FBXExporter_AddRecorder.png)
 

com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorder.cs

@@ -1,4 +1,5 @@
-using System.Collections;
+#if ENABLE_FBX_RECORDER
+using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 using UnityEditor.Recorder;
@@ -72,3 +73,4 @@ protected override void EndRecording(RecordingSession session)
         }
     }
 }
+#endif // ENABLE_FBX_RECORDER

com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorderSettings.cs

@@ -1,4 +1,5 @@
-using System;
+#if ENABLE_FBX_RECORDER
+using System;
 using System.Collections.Generic;
 using UnityEngine;
 using UnityEditor.Recorder;
@@ -279,4 +280,5 @@ protected override string Extension
             get { return "fbx"; }
         }
     }
-}
+}
+#endif // ENABLE_FBX_RECORDER

com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorderSettingsEditor.cs

@@ -1,4 +1,5 @@
-using System.Collections;
+#if ENABLE_FBX_RECORDER
+using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 using UnityEditor.Recorder;
@@ -36,3 +37,4 @@ protected override void OnEncodingGui()
         }
     }
 }
+#endif // ENABLE_FBX_RECORDER

com.unity.formats.fbx/Editor/Unity.Formats.Fbx.Editor.asmdef

@@ -17,6 +17,12 @@
     "precompiledReferences": [],
     "autoReferenced": true,
     "defineConstraints": [],
-    "versionDefines": [],
+    "versionDefines": [
+        {
+            "name": "com.unity.recorder",
+            "expression": "2.2.0-preview.4",
+            "define": "ENABLE_FBX_RECORDER"
+        }
+    ],
     "noEngineReferences": false
 }

com.unity.formats.fbx/package.json

@@ -3,11 +3,10 @@
   "displayName": "FBX Exporter",
   "version": "4.0.0-pre.1",
   "dependencies": {
-    "com.unity.recorder": "2.2.0-preview.4",
     "com.unity.timeline": "1.0.0",
     "com.autodesk.fbx": "4.0.0-pre.1"
   },
-  "unity": "2018.4",
+  "unity": "2019.4",
   "unityRelease": "0f1",
   "description": "The Unity FBX Exporter package makes it easy to send geometry and animation to any application that supports FBX and back again with minimal effort.\n\nIn particular, this round-trip workflow enables you to export Unity scenes to FBX, import into Maya, Maya LT, or 3ds Max using an artist-friendly interface, export Unity-ready FBX geometry and animation, and safely merge your changes back into those Assets to continue your work.\n\nFor more information, see the FBX Exporter package documentation.",
   "keywords": [