Merge pull request #376 from Unity-Technologies/UNI-43868-compatible-naming-convert-confirmation

Uni 43868 compatible naming convert warning dialog

Author: vkovec

Assets/FbxExporters/Editor/ConvertToModel.cs

@@ -104,7 +104,7 @@ public static GameObject Convert (
                 string fbxFullPath = null,
                 string prefabDirectoryFullPath = null,
                 string prefabFullPath = null, 
-                EditorTools.IExportOptions exportOptions = null
+                EditorTools.ConvertToPrefabSettingsSerialize exportOptions = null
             )
             {
                 // Only create the prefab (no FBX export) if we have selected the root of a model prefab instance.
@@ -139,7 +139,7 @@ public static GameObject Convert (
                 // The import back in to Unity would do this automatically but
                 // we prefer to control it so that the Maya artist can see the
                 // same names as exist in Unity.
-                EnforceUniqueNames (new GameObject[] {toConvert});
+                EnforceUniqueNames(new GameObject[] { toConvert });
 
                 // Export to FBX. It refreshes the database.
                 {
@@ -282,23 +282,28 @@ public static string IncrementFileName(string path, string filename)
             /// <param name="exportSet">Export set.</param>
             public static void EnforceUniqueNames(IEnumerable<GameObject> exportSet)
             {
-                Dictionary<string, int> NameToIndexMap = new Dictionary<string, int> ();
+                Dictionary<string, int> NameToIndexMap = new Dictionary<string, int>();
                 string format = "{0} {1}";
 
-                Queue<GameObject> queue = new Queue<GameObject> (exportSet);
+                Queue<GameObject> queue = new Queue<GameObject>(exportSet);
 
-                while(queue.Count > 0){
-                    var go = queue.Dequeue ();
+                while (queue.Count > 0)
+                {
+                    var go = queue.Dequeue();
                     var name = go.name;
-                    if (NameToIndexMap.ContainsKey (name)) {
-                        go.name = string.Format (format, name, NameToIndexMap [name]);
-                        NameToIndexMap [name]++;
-                    } else {
-                        NameToIndexMap [name] = 1;
+                    if (NameToIndexMap.ContainsKey(name))
+                    {
+                        go.name = string.Format(format, name, NameToIndexMap[name]);
+                        NameToIndexMap[name]++;
+                    }
+                    else
+                    {
+                        NameToIndexMap[name] = 1;
                     }
 
-                    foreach (Transform child in go.transform) {
-                        queue.Enqueue (child.gameObject);
+                    foreach (Transform child in go.transform)
+                    {
+                        queue.Enqueue(child.gameObject);
                     }
                 }
             }

Assets/FbxExporters/Editor/ConvertToPrefabEditorWindow.cs

@@ -82,6 +82,19 @@ protected override void OnEnable ()
                 m_prefabExtLabelWidth = m_fbxExtLabelStyle.CalcSize (new GUIContent (".prefab")).x;
             }
 
+            protected bool ExportSetContainsAnimation ()
+            {
+                foreach(var obj in ToExport)
+                {
+                    var go = ModelExporter.GetGameObject(obj);
+                    if(go.GetComponentInChildren<Animation>() || go.GetComponentInChildren<Animator>())
+                    {
+                        return true;
+                    }
+                }
+                return false;
+            }
+
             protected override bool Export ()
             {
                 if (string.IsNullOrEmpty (m_exportFileName)) {
@@ -105,6 +118,29 @@ protected override bool Export ()
                     return false;
                 }
 
+                if (SettingsObject.UseMayaCompatibleNames && SettingsObject.AllowSceneModification)
+                {
+                    string warning = "Names of objects in the hierarchy may change with the Compatible Naming option turned on";
+                    if (ExportSetContainsAnimation())
+                    {
+                        warning = "Compatible Naming option turned on. Names of objects in hierarchy may change and break animations.";
+                    }
+
+                    // give a warning dialog that indicates that names in the scene may change
+                    int result = UnityEditor.EditorUtility.DisplayDialogComplex(
+                                    string.Format("{0} Warning", ModelExporter.PACKAGE_UI_NAME), warning, "OK", "Turn off and continue", "Cancel"
+                                );
+                    if (result == 1)
+                    {
+                        // turn compatible naming off
+                        SettingsObject.SetUseMayaCompatibleNames(false);
+                    }
+                    else if (result == 2)
+                    {
+                        return false;
+                    }
+                }
+
                 if (ToExport.Length == 1) {
                     var go = ModelExporter.GetGameObject (ToExport [0]);
 

Assets/FbxExporters/Editor/ConvertToPrefabSettings.cs

@@ -76,5 +76,6 @@ public class ConvertToPrefabSettingsSerialize : ExportOptionsSettingsSerializeBa
         public override ExportSettings.LODExportType LODExportType { get { return ExportSettings.LODExportType.All; } }
         public override ExportSettings.ObjectPosition ObjectPosition { get { return ExportSettings.ObjectPosition.Reset; } }
         public override bool ExportUnrendered { get { return true; } }
+        public override bool AllowSceneModification { get { return true; } }
     }
 }

Assets/FbxExporters/Editor/ExportModelSettings.cs

@@ -105,6 +105,7 @@ public interface IExportOptions {
         ExportSettings.ObjectPosition ObjectPosition { get; }
         bool AnimateSkinnedMesh { get; }
         bool UseMayaCompatibleNames { get; }
+        bool AllowSceneModification { get; }
         bool ExportUnrendered { get; }
         Transform AnimationSource { get; }
         Transform AnimationDest { get; }
@@ -145,6 +146,7 @@ public abstract class ExportOptionsSettingsSerializeBase : IExportOptions
         public abstract ExportSettings.LODExportType LODExportType { get; }
         public abstract ExportSettings.ObjectPosition ObjectPosition { get; }
         public abstract bool ExportUnrendered { get; }
+        public abstract bool AllowSceneModification { get; }
     }
 
     [System.Serializable]
@@ -163,5 +165,6 @@ public class ExportModelSettingsSerialize : ExportOptionsSettingsSerializeBase
         public void SetObjectPosition(ExportSettings.ObjectPosition objPos){ this.objectPosition = objPos; }
         public override bool ExportUnrendered { get { return exportUnrendered; } }
         public void SetExportUnredererd(bool exportUnrendered){ this.exportUnrendered = exportUnrendered; }
+        public override bool AllowSceneModification { get { return false; } }
     }
 }

Assets/FbxExporters/Editor/FbxExporter.cs

@@ -2212,6 +2212,10 @@ protected int ExportTransformHierarchy(
                 string fbxName = unityGo.name;
                 if (ExportOptions.UseMayaCompatibleNames) {
                     fbxName = ConvertToMayaCompatibleName (unityGo.name);
+                    if (ExportOptions.AllowSceneModification)
+                    {
+                        unityGo.name = fbxName;
+                    }
                 }
 
                 // create an FbxNode and add it as a child of parent