Added .NET 4.5 output and removed OpenCover

Author: TwoTenPvP

MLAPI-Editor/MLAPI-Editor.csproj

@@ -2,7 +2,7 @@
   <Import Project="../common.props" />
   <PropertyGroup>
     <RootNamespace>MLAPI_Editor</RootNamespace>
-    <TargetFrameworks>net35;net471;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net35;net471;net45;netstandard2.0</TargetFrameworks>
     <AssemblyTitle>MLAPI-Editor</AssemblyTitle>
     <Product>MLAPI-Editor</Product>
     <LangVersion>7</LangVersion>

MLAPI-Examples/MLAPI-Examples.csproj

@@ -2,7 +2,7 @@
   <Import Project="../common.props" />
   <PropertyGroup>
     <RootNamespace>MLAPI_Examples</RootNamespace>
-    <TargetFrameworks>net35;net471;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net35;net471;net45;netstandard2.0</TargetFrameworks>
     <AssemblyTitle>MLAPI-Examples</AssemblyTitle>
     <Product>MLAPI-Examples</Product>
   </PropertyGroup>

MLAPI-Tests/MLAPI-Tests.csproj

@@ -2,12 +2,11 @@
   <Import Project="../common.props" />
   <PropertyGroup>
     <RootNamespace>MLAPI_Tests</RootNamespace>
-    <TargetFrameworks>net35;net471;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net35;net471;net45;netstandard2.0</TargetFrameworks>
     <LangVersion>7</LangVersion>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="NUnit" Version="3.10.1" />
-    <PackageReference Include="OpenCover" Version="4.6.519" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\MLAPI\MLAPI.csproj" />

MLAPI/MLAPI.csproj

@@ -8,7 +8,7 @@
     <Description>Game networking stack for Unity.</Description>
     <Version>6.0.0</Version>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <TargetFrameworks>net35;net471;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net35;net471;net45;netstandard2.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

MLAPI/MonoBehaviours/Core/NetworkingManager.cs

@@ -915,9 +915,6 @@ private void HandleIncomingData(uint clientId, byte[] data, int channelId, int t
             }
         }
 
-#if NET45
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-#endif
         internal void DisconnectClient(uint clientId)
         {
             if (!IsServer)

appveyor.yml

@@ -23,53 +23,43 @@ artifacts:
 
 image: Visual Studio 2017
 
-install: 
-  - cd C:\
-  - cmd: mkdir testOutput
-  - if not exist opencover.zip appveyor DownloadFile "https://github.com/OpenCover/opencover/releases/download/4.6.519/opencover.4.6.519.zip" -FileName opencover.zip
-  - 7z x -y opencover.zip -o"C:\opencover" > nul
-
 before_build:
-  - cd %appveyor_build_folder%
   - nuget restore
 
 for:
 -
   matrix:
     only:
       - configuration: Debug
-  test_script:
-  - C:\OpenCover\OpenCover.Console.exe -returntargetcode -register:user -target:"nunit3-console.exe" -targetargs:"MLAPI-Tests\bin\Debug\net35\MLAPI-Tests.dll" -output:"coverage.xml" -filter:"+[MLAPI*]* -[MLAPI-Tests*]* "
   artifacts:
-  - path: 'MLAPI\bin\Debug\net35\MLAPI*'
+  - path: 'MLAPI\bin\Debug\*\*MLAPI*'
+  test:
+    assemblies:
+      - 'MLAPI\bin\Debug\*\MLAPI.dll'
 -
   matrix:
     only:
       - configuration: Debug_Lite
-  test_script:
-  - C:\OpenCover\OpenCover.Console.exe -returntargetcode -register:user -target:"nunit3-console.exe" -targetargs:"MLAPI-Tests\bin\Lite\Debug\net35\MLAPI-Tests.dll" -output:"coverage.xml" -filter:"+[MLAPI*]* -[MLAPI-Tests*]* "
   artifacts:
-  - path: 'MLAPI\bin\Lite\Debug\net35\MLAPI*'
+  - path: 'MLAPI\bin\Lite\Debug\*\*MLAPI*'
+  test:
+    assemblies:
+      - 'MLAPI\bin\Lite\Debug\*\MLAPI.dll'
 -
   matrix:
     only:
       - configuration: Release
-  test_script:
-  - C:\OpenCover\OpenCover.Console.exe -returntargetcode -register:user -target:"nunit3-console.exe" -targetargs:"MLAPI-Tests\bin\Release\net35\MLAPI-Tests.dll" -output:"coverage.xml" -filter:"+[MLAPI*]* -[MLAPI-Tests*]* "
   artifacts:
-  - path: 'MLAPI\bin\Release\net35\MLAPI*'
+  - path: 'MLAPI\bin\Release\*\*MLAPI*'
+  test:
+    assemblies:
+      - 'MLAPI\bin\Release\*\MLAPI.dll'
 -
   matrix:
     only:
       - configuration: Release_Lite
-  test_script:
-  - C:\OpenCover\OpenCover.Console.exe -returntargetcode -register:user -target:"nunit3-console.exe" -targetargs:"MLAPI-Tests\bin\Lite\Release\net35\MLAPI-Tests.dll" -output:"coverage.xml" -filter:"+[MLAPI*]* -[MLAPI-Tests*]* "
   artifacts:
-  - path: 'MLAPI\bin\Lite\Release\net35\MLAPI*'
-
-
-after_test:
-  - ps: |
-      $env:PATH = 'C:\msys64\usr\bin;' + $env:PATH
-      Invoke-WebRequest -Uri 'https://codecov.io/bash' -OutFile codecov.sh
-      bash codecov.sh -f "coverage.xml" 
+  - path: 'MLAPI\bin\Lite\Release\*\*MLAPI*'
+  test:
+    assemblies:
+      - 'MLAPI\bin\Lite\Release\*\MLAPI.dll'