fix: Fix destroying object with custom handlers (#339)

TwoTenPvP · rivFox · web-flow · commit 5d48f4b708f2 · 2020-05-13T16:33:11.000+02:00
* Fix destroying object with custom handlers

* fix: Proper fix

Co-authored-by: Bartłomiej Jarosz &lt;rivfox.jb@gmail.com&gt;
diff --git a/MLAPI/Spawning/SpawnManager.cs b/MLAPI/Spawning/SpawnManager.cs
@@ -517,7 +517,7 @@ internal static void ServerResetShudownStateForSceneObjects()
 
         internal static void ServerDestroySpawnedSceneObjects()
         {
-            for (int i = 0; i < SpawnedObjectsList.Count; i++)
+            for (int i = SpawnedObjectsList.Count - 1; i >= 0; i--)
             {
                 if ((SpawnedObjectsList[i].IsSceneObject != null && SpawnedObjectsList[i].IsSceneObject == true) || SpawnedObjectsList[i].DestroyWithScene)
                 {

Original file line number	Diff line number	Diff line change
`@@ -517,7 +517,7 @@ internal static void ServerResetShudownStateForSceneObjects()`
`517`	`517`
`518`	`518`	`internal static void ServerDestroySpawnedSceneObjects()`
`519`	`519`	`{`
`520`		`- for (int i = 0; i < SpawnedObjectsList.Count; i++)`
	`520`	`+ for (int i = SpawnedObjectsList.Count - 1; i >= 0; i--)`
`521`	`521`	`{`
`522`	`522`	`if ((SpawnedObjectsList[i].IsSceneObject != null && SpawnedObjectsList[i].IsSceneObject == true) \|\| SpawnedObjectsList[i].DestroyWithScene)`
`523`	`523`	`{`