Merge branch 'develop-2.0.0' into fix/localhost-resolution

Author: simon-lemay-unity

.github/pull_request_template.md

@@ -1,36 +1,61 @@
-<!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. -->
+## Purpose of this PR
+[//]: # (
+Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. 
+)
 
-<!-- Add short version of the JIRA ticket to the PR title (e.g. "feat: new shiny feature [MTT-123]") -->
+### Jira ticket
+_Link to related jira ticket ([Use the smart commits](https://support.atlassian.com/bitbucket-cloud/docs/use-smart-commits/))_
 
-## Changelog
+### Changelog
+[//]: # (updated with all public facing changes  - API changes, UI/UX changes, behaviour changes, bug fixes. Remove if not relevant.)
 
 - Added: The package whose Changelog should be added to should be in the header. Delete the changelog section entirely if it's not needed.
-- Fixed: If you update multiple packages, create a new section with a new header for the other package. 
-- Removed/Deprecated/Changed: Each bullet should be prefixed with Added, Fixed, Removed, Deprecated, or Changed to indicate where the entry should go.
-
-## Testing and Documentation
-
-- No tests have been added.
-- Includes unit tests.
-- Includes integration tests.
-- No documentation changes or additions were necessary.
-- Includes documentation for previously-undocumented public API entry points.
-- Includes edits to existing public API documentation.
+- Fixed: If you update multiple packages, create a new section with a new header for the other package.
+- Removed/Deprecated/Changed: Each bullet should be prefixed with Added, Fixed, Removed, Deprecated, or Changed to indicate where the entry should go
 
 <!--  Uncomment and mark items off with a * if this PR deprecates any API:
 ### Deprecated API
 - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry.
-- [ ] An [api updater] was added.
+- [ ] An [api updater](https://confluence.unity3d.com/display/DEV/Obsolete+API+updaters) was added.
 - [ ] Deprecation of the API is explained in the CHANGELOG.
 - [ ] The users can understand why this API was removed and what they should use instead.
 -->
 
-## Backport
+## Documentation
+[//]: # (
+This section is REQUIRED and should mention what documentation changes were following the changes in this PR. 
+We should always evaluate if the changes in this PR require any documentation changes.
+)
 
-<!-- If this is a backport:
- - Add the following to the PR title: "\[Backport\] ..." .
- - Link to the original PR.
-If this needs a backport - state this here
-If a backport is not needed please provide the reason why.
-If the "Backports" section is not present it will lead to a CI test failure. 
--->
+- No documentation changes or additions were necessary.
+- Includes documentation for previously-undocumented public API entry points.
+- Includes edits to existing public API documentation.
+
+## Testing & QA
+[//]: #  (
+This section is REQUIRED and should describe how the changes were tested and how should they be tested when Playtesting for the release.
+It can range from "edge case covered by unit tests" to "manual testing required and new sample was added".
+Expectation is that PR creator does some manual testing and provides a summary of it here.)
+
+### Functional Testing
+[//]: # (If checked, List manual tests that have been performed.)
+_Manual testing :_
+- [ ] `Manual testing done`
+
+_Automated tests:_
+- [ ] `Covered by existing automated tests`
+- [ ] `Covered by new automated tests`
+
+_Does the change require QA team to:_
+
+- [ ] `Review automated tests`?
+- [ ] `Execute manual tests`?
+
+If any boxes above are checked, please add QA as a PR reviewer.
+
+## Backport
+[//]: # (
+This section is REQUIRED and should link to the PR that targets other NGO version which is either develop or develop-2.0.0 branch
+Add the following to the PR title: "\[Backport\] ..."
+If this is not needed, for example feature specific to NGOv2.X, then just mention this fact.
+)

.github/workflows/backport-verification.yml

@@ -0,0 +1,62 @@
+# This workflow is designed to verify that the pull request description contains a required sections that are important from quality perspective.
+# ## Backport section is important as a reminder to account for backports for anyone that works with NGO repository (to 1.X or 2.X branches respectively).
+# ## Testing & QA section is important to ensure that the PR has appropriate testing coverage and is important when QA will evaluate PRs before Playtesting for the release.
+# ## Documentation section is important to ensure that the documentation is updated with the changes made in the PR.
+
+# If any of the sections is missing, the workflow will fail and block the PR from merging, prompting the developer to add those sections to the PR description.
+# The workflow is configured to run when PR is created as well as when it is edited which also counts simple description edits.
+
+name: "NGO - PR Verification"
+
+on:
+  pull_request:
+    types: [opened, edited, synchronize, reopened]
+    branches:
+      - develop
+      - develop-2.0.0
+      - release/*
+
+jobs:
+  pr-verification:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Check PR description
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const pr = context.payload.pull_request;
+            const body = pr.body || '';
+
+            // List of mandatory PR sections
+            const requiredSections = [
+              {
+                header: '## Backport',
+                description: 'PR description must include a "## Backport" section. Please add this section and provide information about this PR backport to develop or develop-2.0.0 branch respectively or explain why backport is not needed.'
+              },
+              {
+                header: '## Testing & QA',
+                description: 'PR description must include a "## Testing & QA" section. Please add this section and provide information about the testing performed for this PR. It can range from adding unit tests to full samples and is needed from QA side to analyze PRs while Playtesting for the release.'
+              },
+              {
+                header: '## Documentation',
+                description: 'PR description must include a "## Documentation" section. Please add this section and provide information about the documentation changes made in this PR. It is important to keep the documentation up to date with the code changes.'
+              }
+            ];
+
+            const missing = requiredSections.filter(section => !body.includes(section.header));
+
+            if (missing.length > 0) {
+              let message = 'PR description is missing the following required section(s):\n';
+
+              const missingDescriptions = missing.map(
+                s => `- ${s.header}: ${s.description}`
+              );
+
+              message += missingDescriptions.join('\n');
+              message += '\n\nPlease add them to your PR description.';
+
+              core.setFailed(message);
+            }

.github/workflows/pr-verification.yml

@@ -10,6 +10,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 
 ### Added
 
+- Added `AsNativeArray()` read‑only accessor to `NetworkList<T>` (#3567)
 
 ### Fixed
 
@@ -20,6 +21,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 ### Changed
 
 - Marked `UnityTransport.ConnectionAddressData.ServerEndPoint` as obsolete. It can't work when using hostnames as the server address, and its functionality can easily be replicated using `NetworkEndpoint.Parse`. (#3591)
+- Optimized `NetworkList<T>` indexer setter to skip operations when the new value equals the existing value, improving performance by avoiding unnecessary list events and network synchronization. (#3587)
 
 ## [2.5.0] - 2025-08-01
 
@@ -32,6 +34,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
 
 ### Fixed
 
+- Removed allocation to the heap in NetworkBehaviourUpdate. (#3573)
 - Fixed issue where NetworkConfig.ConnectionData could cause the ConnectionRequestMessage to exceed the transport's MTU size and would result in a buffer overflow error. (#3564)
 - Fixed regression issue in v2.x where `NetworkObject.GetNetworkBehaviourAtOrderIndex` was converted from public to internal. (#3541)
 - Fixed ensuring OnValueChanged callback is still triggered on the authority when a collection changes and then reverts to the previous value in the same frame. (#3539)

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -34,7 +34,10 @@ internal void NetworkBehaviourUpdate(bool forceSend = false)
 #endif
             try
             {
-                m_DirtyNetworkObjects.UnionWith(m_PendingDirtyNetworkObjects);
+                foreach (var dirtyNetworkObject in m_PendingDirtyNetworkObjects)
+                {
+                    m_DirtyNetworkObjects.Add(dirtyNetworkObject);
+                }
                 m_PendingDirtyNetworkObjects.Clear();
 
                 // NetworkObject references can become null, when hidden or despawned. Once NUll, there is no point

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs

@@ -617,6 +617,13 @@ public T this[int index]
                 }
 
                 var previousValue = m_List[index];
+
+                // Only trigger an event if the value has changed
+                if (NetworkVariableSerialization<T>.AreEqual(ref previousValue, ref value))
+                {
+                    return;
+                }
+
                 m_List[index] = value;
 
                 var listEvent = new NetworkListEvent<T>()
@@ -631,6 +638,24 @@ public T this[int index]
             }
         }
 
+        /// <summary>
+        /// Gets a **zero‑allocation**, <see cref="NativeArray{T}.ReadOnly"/> view over the current
+        /// elements of this <see cref="NetworkList{T}"/>.
+        /// </summary>
+        /// <remarks>
+        /// The returned array stays valid **only until** the list is mutated (add, remove,
+        /// clear, resize) or <see cref="Dispose()"/> is called on the container.  Continuing to use
+        /// the array after it is invalid will result in undefined behaviour;
+        /// callers are responsible for ensuring a safe lifetime.
+        /// </remarks>
+        /// <returns>
+        /// A <see cref="NativeArray{T}.ReadOnly"/> reference that shares the same backing memory as this list.
+        /// </returns>
+        public NativeArray<T>.ReadOnly AsNativeArray()
+        {
+            return m_List.AsReadOnly();
+        }
+
         private void HandleAddListEvent(NetworkListEvent<T> listEvent)
         {
             m_DirtyEvents.Add(listEvent);