fix: network variables were reporting the incorrect sizes (#1844)

becksebenius-unity · web-flow · commit b72456c75143 · 2022-03-28T19:24:19.000Z
diff --git a/com.unity.netcode.gameobjects/Runtime/Messaging/Messages/NetworkVariableDeltaMessage.cs b/com.unity.netcode.gameobjects/Runtime/Messaging/Messages/NetworkVariableDeltaMessage.cs
@@ -48,6 +48,7 @@ public void Serialize(FastBufferWriter writer)
                     continue;
                 }
 
+                var startingSize = writer.Length;
                 var networkVariable = NetworkBehaviour.NetworkVariableFields[i];
                 var shouldWrite = networkVariable.IsDirty() &&
                     networkVariable.CanClientRead(TargetClientId) &&
@@ -96,7 +97,7 @@ public void Serialize(FastBufferWriter writer)
                         NetworkBehaviour.NetworkObject,
                         networkVariable.Name,
                         NetworkBehaviour.__getTypeName(),
-                        writer.Length);
+                        writer.Length - startingSize);
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,7 @@ public void Serialize(FastBufferWriter writer)`
`48`	`48`	`continue;`
`49`	`49`	`}`
`50`	`50`
	`51`	`+ var startingSize = writer.Length;`
`51`	`52`	`var networkVariable = NetworkBehaviour.NetworkVariableFields[i];`
`52`	`53`	`var shouldWrite = networkVariable.IsDirty() &&`
`53`	`54`	`networkVariable.CanClientRead(TargetClientId) &&`
`@@ -96,7 +97,7 @@ public void Serialize(FastBufferWriter writer)`
`96`	`97`	`NetworkBehaviour.NetworkObject,`
`97`	`98`	`networkVariable.Name,`
`98`	`99`	`NetworkBehaviour.__getTypeName(),`
`99`		`- writer.Length);`
	`100`	`+ writer.Length - startingSize);`
`100`	`101`	`}`
`101`	`102`	`}`
`102`	`103`	`}`