update

Still had one more line of code needed to go back to original lerp buffer consumption where the time to target is always 2x the actual time to target (it ends up consuming 2 state updates for each non-authority update).

Making sure some of the debugging BLI accessor methods in NetworkTransform are still accessible for internal testing purposes.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Components/Interpolator/BufferedLinearInterpolator.cs

@@ -477,55 +477,58 @@ internal T Update(float deltaTime, double tickLatencyAsTime, double minDeltaTime
         /// <param name="renderTime"></param>
         private void TryConsumeFromBuffer(double renderTime, double serverTime)
         {
-            BufferedItem? previousItem = null;
-            var alreadyHasBufferItem = false;
-            while (m_BufferQueue.TryPeek(out BufferedItem potentialItem))
+            if (!InterpolateState.Target.HasValue || (InterpolateState.Target.Value.TimeSent <= renderTime))
             {
-                // If we are still on the same buffered item (FIFO Queue), then exit early as there is nothing
-                // to consume.
-                if (previousItem.HasValue && previousItem.Value.TimeSent == potentialItem.TimeSent)
+                BufferedItem? previousItem = null;
+                var alreadyHasBufferItem = false;
+                while (m_BufferQueue.TryPeek(out BufferedItem potentialItem))
                 {
-                    break;
-                }
+                    // If we are still on the same buffered item (FIFO Queue), then exit early as there is nothing
+                    // to consume.
+                    if (previousItem.HasValue && previousItem.Value.TimeSent == potentialItem.TimeSent)
+                    {
+                        break;
+                    }
 
-                if ((potentialItem.TimeSent <= serverTime) &&
-                    (!InterpolateState.Target.HasValue || InterpolateState.Target.Value.TimeSent < potentialItem.TimeSent))
-                {
-                    if (m_BufferQueue.TryDequeue(out BufferedItem target))
+                    if ((potentialItem.TimeSent <= serverTime) &&
+                        (!InterpolateState.Target.HasValue || InterpolateState.Target.Value.TimeSent < potentialItem.TimeSent))
                     {
-                        if (!InterpolateState.Target.HasValue)
-                        {
-                            InterpolateState.Target = target;
-                            alreadyHasBufferItem = true;
-                            InterpolateState.PreviousValue = InterpolateState.CurrentValue;
-                            InterpolateState.StartTime = target.TimeSent;
-                            InterpolateState.EndTime = target.TimeSent;
-                        }
-                        else
+                        if (m_BufferQueue.TryDequeue(out BufferedItem target))
                         {
-                            if (!alreadyHasBufferItem)
+                            if (!InterpolateState.Target.HasValue)
                             {
+                                InterpolateState.Target = target;
                                 alreadyHasBufferItem = true;
-                                InterpolateState.StartTime = InterpolateState.Target.Value.TimeSent;
                                 InterpolateState.PreviousValue = InterpolateState.CurrentValue;
-                                InterpolateState.TargetReached = false;
+                                InterpolateState.StartTime = target.TimeSent;
+                                InterpolateState.EndTime = target.TimeSent;
+                            }
+                            else
+                            {
+                                if (!alreadyHasBufferItem)
+                                {
+                                    alreadyHasBufferItem = true;
+                                    InterpolateState.StartTime = InterpolateState.Target.Value.TimeSent;
+                                    InterpolateState.PreviousValue = InterpolateState.CurrentValue;
+                                    InterpolateState.TargetReached = false;
+                                }
+                                InterpolateState.EndTime = target.TimeSent;
+                                InterpolateState.Target = target;
+                                InterpolateState.TimeToTargetValue = InterpolateState.EndTime - InterpolateState.StartTime;
                             }
-                            InterpolateState.EndTime = target.TimeSent;
-                            InterpolateState.Target = target;
-                            InterpolateState.TimeToTargetValue = InterpolateState.EndTime - InterpolateState.StartTime;
                         }
                     }
-                }
-                else
-                {
-                    break;
-                }
+                    else
+                    {
+                        break;
+                    }
 
-                if (!InterpolateState.Target.HasValue)
-                {
-                    break;
+                    if (!InterpolateState.Target.HasValue)
+                    {
+                        break;
+                    }
+                    previousItem = potentialItem;
                 }
-                previousItem = potentialItem;
             }
         }
 

com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs

@@ -4003,7 +4003,7 @@ public void Teleport(Vector3 newPosition, Quaternion newRotation, Vector3 newSca
         #region UPDATES AND AUTHORITY CHECKS
         private NetworkTransformTickRegistration m_NetworkTransformTickRegistration;
 
-#if DEBUG_LINEARBUFFER && UNITY_EDITOR
+#if DEBUG_LINEARBUFFER
 #if UNITY_EDITOR
         // For debugging purposes
         public struct BufferEntry