Skip to content

Commit d0a4784

Browse files
committed
Renamed Read & Write interface methods
1 parent c5cbbc1 commit d0a4784

File tree

4 files changed

+18
-23
lines changed

4 files changed

+18
-23
lines changed

MLAPI/Data/NetworkedCollections/NetworkedDictionary.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using System;
2-
using System.Collections;
1+
using System.Collections;
32
using System.Collections.Generic;
43
using MLAPI.MonoBehaviours.Core;
54
using MLAPI.NetworkingManagerComponents.Binary;
@@ -76,7 +75,7 @@ public string GetChannel()
7675
}
7776

7877
/// <inheritdoc />
79-
public void SetDeltaFromReader(BitReader reader)
78+
public void ReadDelta(BitReader reader)
8079
{
8180
ushort deltaCount = reader.ReadUShort();
8281
for (int i = 0; i < deltaCount; i++)
@@ -120,7 +119,7 @@ public void SetDeltaFromReader(BitReader reader)
120119
}
121120

122121
/// <inheritdoc />
123-
public void SetFieldFromReader(BitReader reader)
122+
public void ReadField(BitReader reader)
124123
{
125124
ushort entryCount = reader.ReadUShort();
126125

@@ -144,7 +143,7 @@ public bool TryGetValue(TKey key, out TValue value)
144143
}
145144

146145
/// <inheritdoc />
147-
public void WriteDeltaToWriter(BitWriter writer)
146+
public void WriteDelta(BitWriter writer)
148147
{
149148
writer.WriteUShort((ushort)dirtyEvents.Count);
150149
for (int i = 0; i < dirtyEvents.Count; i++)
@@ -187,7 +186,7 @@ public void WriteDeltaToWriter(BitWriter writer)
187186
}
188187

189188
/// <inheritdoc />
190-
public void WriteFieldToWriter(BitWriter writer)
189+
public void WriteField(BitWriter writer)
191190
{
192191
writer.WriteUShort((ushort)dictionary.Count);
193192
for (int i = 0; i < dictionary.Count; i++)

MLAPI/Data/NetworkedCollections/NetworkedList.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
using System.Collections.Generic;
33
using MLAPI.MonoBehaviours.Core;
44
using MLAPI.NetworkingManagerComponents.Binary;
5-
using MLAPI.NetworkingManagerComponents.Core;
65

76
namespace MLAPI.Data.NetworkedCollections
87
{
@@ -127,7 +126,7 @@ public bool CanClientRead(uint clientId)
127126
}
128127

129128
/// <inheritdoc />
130-
public void WriteDeltaToWriter(BitWriter writer)
129+
public void WriteDelta(BitWriter writer)
131130
{
132131
writer.WriteUShort((ushort)dirtyEvents.Count);
133132
for (int i = 0; i < dirtyEvents.Count; i++)
@@ -174,7 +173,7 @@ public void WriteDeltaToWriter(BitWriter writer)
174173
}
175174

176175
/// <inheritdoc />
177-
public void WriteFieldToWriter(BitWriter writer)
176+
public void WriteField(BitWriter writer)
178177
{
179178
writer.WriteUShort((ushort)list.Count);
180179
for (int i = 0; i < list.Count; i++)
@@ -184,7 +183,7 @@ public void WriteFieldToWriter(BitWriter writer)
184183
}
185184

186185
/// <inheritdoc />
187-
public void SetFieldFromReader(BitReader reader)
186+
public void ReadField(BitReader reader)
188187
{
189188
ushort count = reader.ReadUShort();
190189
for (int i = 0; i < count; i++)
@@ -194,7 +193,7 @@ public void SetFieldFromReader(BitReader reader)
194193
}
195194

196195
/// <inheritdoc />
197-
public void SetDeltaFromReader(BitReader reader)
196+
public void ReadDelta(BitReader reader)
198197
{
199198
ushort deltaCount = reader.ReadUShort();
200199
for (int i = 0; i < deltaCount; i++)

MLAPI/Data/NetworkedVar.cs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
using MLAPI.NetworkingManagerComponents.Binary;
22
using MLAPI.MonoBehaviours.Core;
3-
using MLAPI.NetworkingManagerComponents.Core;
4-
using System;
53
using System.Collections.Generic;
64

75
namespace MLAPI.Data
@@ -116,7 +114,7 @@ public bool CanClientRead(uint clientId)
116114
/// Writes the variable to the writer
117115
/// </summary>
118116
/// <param name="writer">The writer to write the value to</param>
119-
public void WriteDeltaToWriter(BitWriter writer) => WriteFieldToWriter(writer); //The NetworkedVar is built for simple data types and has no delta.
117+
public void WriteDelta(BitWriter writer) => WriteField(writer); //The NetworkedVar is built for simple data types and has no delta.
120118

121119
/// <inheritdoc />
122120
public bool CanClientWrite(uint clientId)
@@ -143,7 +141,7 @@ public bool CanClientWrite(uint clientId)
143141
/// Reads value from the reader and applies it
144142
/// </summary>
145143
/// <param name="reader">The reader to read the value from</param>
146-
public void SetDeltaFromReader(BitReader reader) => SetFieldFromReader(reader); //The NetworkedVar is built for simple data types and has no delta.
144+
public void ReadDelta(BitReader reader) => ReadField(reader); //The NetworkedVar is built for simple data types and has no delta.
147145

148146
/// <inheritdoc />
149147
public void SetNetworkedBehaviour(NetworkedBehaviour behaviour)
@@ -152,7 +150,7 @@ public void SetNetworkedBehaviour(NetworkedBehaviour behaviour)
152150
}
153151

154152
/// <inheritdoc />
155-
public void SetFieldFromReader(BitReader reader)
153+
public void ReadField(BitReader reader)
156154
{
157155
// TODO TwoTen - Boxing sucks
158156
T previousValue = InternalValue;
@@ -162,7 +160,7 @@ public void SetFieldFromReader(BitReader reader)
162160
}
163161

164162
/// <inheritdoc />
165-
public void WriteFieldToWriter(BitWriter writer)
163+
public void WriteField(BitWriter writer)
166164
{
167165
//TODO: Write field
168166
}
@@ -209,22 +207,22 @@ public interface INetworkedVar
209207
/// Writes the dirty changes, that is, the changes since the variable was last dirty, to the writer
210208
/// </summary>
211209
/// <param name="writer">The writer to write the dirty changes to</param>
212-
void WriteDeltaToWriter(BitWriter writer);
210+
void WriteDelta(BitWriter writer);
213211
/// <summary>
214212
/// Writes the complete state of the variable to the writer
215213
/// </summary>
216214
/// <param name="writer">The writer to write the state to</param>
217-
void WriteFieldToWriter(BitWriter writer);
215+
void WriteField(BitWriter writer);
218216
/// <summary>
219217
/// Reads the complete state from the reader and applies it
220218
/// </summary>
221219
/// <param name="reader">The reader to read the state from</param>
222-
void SetFieldFromReader(BitReader reader);
220+
void ReadField(BitReader reader);
223221
/// <summary>
224222
/// Reads delta from the reader and applies them to the internal value
225223
/// </summary>
226224
/// <param name="reader">The reader to read the delta from</param>
227-
void SetDeltaFromReader(BitReader reader);
225+
void ReadDelta(BitReader reader);
228226
/// <summary>
229227
/// Sets NetworkedBehaviour the container belongs to.
230228
/// </summary>

MLAPI/Data/NetworkedVarMeta.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using MLAPI.Data.Transports;
2-
using MLAPI.MonoBehaviours.Core;
1+
using MLAPI.MonoBehaviours.Core;
32

43
namespace MLAPI.Data
54
{

0 commit comments

Comments
 (0)