Skip to content

Commit d25ccb4

Browse files
update
Some more minor adjustments based on PR feedback.
1 parent 115fbc1 commit d25ccb4

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

com.unity.netcode.gameobjects/Runtime/Transports/NetworkTransport.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ protected void SetDisconnectEvent(DisconnectEvents disconnectEvent, string messa
233233
}
234234
else
235235
{
236-
DisconnectEventMessage = OnGetDisconnectEventMessage(disconnectEvent);
236+
DisconnectEventMessage = GetDisconnectEventMessage(disconnectEvent);
237237
}
238238
}
239239

@@ -242,7 +242,7 @@ protected void SetDisconnectEvent(DisconnectEvents disconnectEvent, string messa
242242
/// </summary>
243243
/// <param name="disconnectEvent">The disconnect event to get from the <see cref="NetworkTransport"/> derived class.</param>
244244
/// <returns><see cref="string.Empty"/> as a default or if overridden the <see cref="string"/> returned.</returns>
245-
protected virtual string OnGetDisconnectEventMessage(DisconnectEvents disconnectEvent)
245+
protected virtual string GetDisconnectEventMessage(DisconnectEvents disconnectEvent)
246246
{
247247
return string.Empty;
248248
}

com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1518,7 +1518,7 @@ public override bool StartServer()
15181518
private UnityTransportNotificationHandler m_UnityTransportNotificationHandler;
15191519

15201520
/// <inheritdoc/>
1521-
protected override string OnGetDisconnectEventMessage(DisconnectEvents disconnectEvent)
1521+
protected override string GetDisconnectEventMessage(DisconnectEvents disconnectEvent)
15221522
{
15231523
return m_UnityTransportNotificationHandler.GetDisconnectEventMessage(disconnectEvent);
15241524
}
@@ -1795,21 +1795,22 @@ internal class UnityTransportNotificationHandler
17951795
private Dictionary<int, NetworkTransport.DisconnectEvents> m_DisconnectEventMap = new Dictionary<int, NetworkTransport.DisconnectEvents>();
17961796
private Dictionary<NetworkTransport.DisconnectEvents, string> m_DisconnectEventMessageMap = new Dictionary<NetworkTransport.DisconnectEvents, string>();
17971797

1798+
/// <summary>
1799+
/// Returns the mapped transport disconnect event id to a <see cref="NetworkTransport.DisconnectEvents"/> value.
1800+
/// </summary>
17981801
internal NetworkTransport.DisconnectEvents GetDisconnectEvent(int disconnectEventId)
17991802
{
18001803
return m_DisconnectEventMap.ContainsKey(disconnectEventId) ? m_DisconnectEventMap[disconnectEventId] : NetworkTransport.DisconnectEvents.Disconnected;
18011804
}
18021805

1806+
/// <summary>
1807+
/// Returns the disconnect event message for the the disconnect event.
1808+
/// </summary>
18031809
public string GetDisconnectEventMessage(NetworkTransport.DisconnectEvents disconnectEvent)
18041810
{
18051811
return m_DisconnectEventMessageMap.ContainsKey(disconnectEvent) ? m_DisconnectEventMessageMap[disconnectEvent] : string.Empty;
18061812
}
18071813

1808-
public void ClosingRemoteConnection()
1809-
{
1810-
1811-
}
1812-
18131814
private void AddDisconnectEventMap(NetworkTransport.DisconnectEvents disconnectEvent, int disconnectReason, string message)
18141815
{
18151816
m_DisconnectEventMap.Add(disconnectReason, disconnectEvent);

0 commit comments

Comments
 (0)