Skip to content

Commit e489606

Browse files
authored
fix: use of culture-sensitive sorting (#327)
1 parent 5d48f4b commit e489606

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

MLAPI/Configuration/NetworkConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ public byte[] ServerX509CertificateBytes
223223

224224
private void Sort()
225225
{
226-
RegisteredScenes.Sort();
226+
RegisteredScenes.Sort(StringComparer.Ordinal);
227227
}
228228

229229
/// <summary>

MLAPI/Core/NetworkedBehaviour.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ private static FieldInfo[] GetFieldInfoForTypeRecursive(Type type, List<FieldInf
258258
}
259259
else
260260
{
261-
return list.OrderBy(x => x.Name).ToArray();
261+
return list.OrderBy(x => x.Name, StringComparer.Ordinal).ToArray();
262262
}
263263
}
264264

MLAPI/Core/NetworkingManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ private void Init(bool server)
388388

389389
if (NetworkConfig.EnableSceneManagement)
390390
{
391-
NetworkConfig.RegisteredScenes.Sort();
391+
NetworkConfig.RegisteredScenes.Sort(StringComparer.Ordinal);
392392

393393
for (int i = 0; i < NetworkConfig.RegisteredScenes.Count; i++)
394394
{

MLAPI/Serialization/SerializationManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ internal static FieldInfo[] GetFieldsForType(Type type)
9898
FieldInfo[] fields = type
9999
.GetFields(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)
100100
.Where(x => (x.IsPublic || x.GetCustomAttributes(typeof(SerializeField), true).Length > 0) && IsTypeSupported(x.FieldType))
101-
.OrderBy(x => x.Name).ToArray();
101+
.OrderBy(x => x.Name, StringComparer.Ordinal).ToArray();
102102

103103
fieldCache.Add(type, fields);
104104

0 commit comments

Comments
 (0)