Skip to content

fix: ping tool example updates and fixes #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix: ping tool example updates and fixes #3106

merged 2 commits into from
Oct 18, 2024

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 18, 2024

This PR resolves the following issues for the PingTool example:

  • PingTool could calculate negative ping times.
  • PingTool could throw an exception on an edge case scenario when exiting a session.
  • Fixed the ServerHostClient identifier sometimes not showing up on-screen.

This PR includes updates to the PingTool example:

  • Using the ExtendedNetworkManager component that uses the NetcodeEditorBase and combines:
    • NetworkManager
    • NetworkManagerHelper
    • OnDisconnectNotify
  • Added a UI Text object to provide on-screen instructions on what key to press to toggle the PingTool.
  • The manifest now points to develop-2.0.0.

Changelog

NA

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
6f3fef6 
Fixed issue with negative ping time calculations.
Fixed issue with potential exception on exiting.
Fixed issue with serverhostclient identifier text not displaying in the render view.
@NoelStephensUnity
update
1309163 
Includes some general updates to the project.
Updated to ExtendedNetworkManager that combines the NetworkManager, NetworkManagerHelper, and DisconnectNotify into a single component.
Added PingToolHelper label that provides on-screen directions as to which key to press to toggle the ping tool.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 18, 2024 18:12
@NoelStephensUnity NoelStephensUnity merged commit 5378d4d into develop-2.0.0 Oct 18, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/examples-pingtool-10-24-fixes branch October 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NoelStephensUnity