feat: Remove DA NetworkVariable modifications #3155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
approved these changes
Dec 6, 2024
Collaborator
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Looks good to me!
Tested with internal asteroids branch and everything seems fine there too.
| } | ||
|
|
||
| // Read the NetworkVarible value | ||
| // Read the NetworkVariable value |
Collaborator
There was a problem hiding this comment.
nice catch both above and below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all serialization logic for NetworkVariables and NetworkBehaviours that was added for the comb-server. The comb-server has already been updated to not use these fields and so now they are safe to remove.
feat: new shiny feature [MTT-9209]
Changelog
NetworkVariableandNetworkBehaviourrelated state store serialization data that the comb server no longer requires.Testing and Documentation