- 
                Notifications
    
You must be signed in to change notification settings  - Fork 462
 
fix: network objects to synchronize scene changes edge cases #3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            NoelStephensUnity
  merged 12 commits into
  develop-2.0.0
from
fix/NetworkObjectsToSynchronizeSceneChanges-edge-cases
  
      
      
   
  Feb 12, 2025 
      
    
                
     Merged
            
            fix: network objects to synchronize scene changes edge cases #3230
                    NoelStephensUnity
  merged 12 commits into
  develop-2.0.0
from
fix/NetworkObjectsToSynchronizeSceneChanges-edge-cases
  
      
      
   
  Feb 12, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …eChanges-edge-cases
              
                    EmandM
  
              
              reviewed
              
                  
                    Feb 11, 2025 
                  
              
              
            
            
        
          
                com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    EmandM
  
              
              approved these changes
              
                  
                    Feb 11, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
The PR assures that:
MTTB-1025
MTTB-1027
This PR also removes the static
NetworkObjectsToSynchronizeSceneChangestable and migrates this script intoNetworkSpawnManager.fix: #3221, #3218
Changelog
GameObjectof aNetworkObjectis destroyed before it should have been.NetworkManagershutting down.Testing and Documentation
NetworkObjectDestroyTestsandNetworkSceneManagerEventDataPoolTest.